Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly validate $ref value escaping #1760

Merged
merged 8 commits into from
May 19, 2018
Merged

fix: properly validate $ref value escaping #1760

merged 8 commits into from
May 19, 2018

Conversation

shockey
Copy link
Contributor

@shockey shockey commented May 19, 2018 •
edited
Loading

Fixes #871.

Depends on swagger-api/swagger-js#1322.

  1. Raise validation errors for unescaped values.
  2. Silence validation errors for properly escaped values.

@shockey shockey merged commit 2ff9d48 into swagger-api:master May 19, 2018
@protegesolutions
Copy link

This creates problems with generated code. Partial escaped codes are embedded in types. Please reverse this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shockey @protegesolutions