Re-implement lookaside for DFS during resolution #1209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cc @shockey - Lets try this again! 😆
In #1190 - the lookaside actually prevented traversal of all properties of a reference - because we marked it as traversed and checked for this traversal before fully iterating the properties in the patch. This means that DFS was never fully complete for a
$ref
that we marked as traversed. This moves the check for previous traversal out of the loop and allows a complete traversal but prevents future traversals. Should be accurate as far as I can tell.I believe this was the root of "required" props not being parsed in swagger-api/swagger-ui#4000
Motivation and Context
Followup to #1201 and #1190. Again reduces resolution times to the #1190 range, but with greater accuracy.
How Has This Been Tested?
All tests pass. Tested with samples from swagger-api/swagger-editor#1585 & swagger-api/swagger-ui#4000 - doesn't appear to break those specs.
@shockey Unsure if there needs to be additional tests - so please grab and test as well! Might need to merge tests from #1201?
Types of changes
package.json
)Checklist: