-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow good practices: Make transition from hashbangs (#!) to javascript pushState #1236
Comments
BTW: I guess Backbone is handling transparently history using #! or push state depending on the browser: http://artsy.github.io/blog/2012/06/25/replacing-hashbang-routes-with-pushstate/ |
Now I'm not so sure if routes and hard links done Backbone-way ie. /pet/addPet are a way to go. Why?
Apart from that changing ba-bbq to better maintained https://github.com/browserstate/history.js/ is probably worth considering sometime in the future. |
Having pushState, would make the urls look cleaner for starters. And moving some more logic into routes would be nice. But it is something to look over, in more detail. |
I'm new to API documentation so forgive me if this is nonsense. I was playing around in the petstore example and noticed using a subroute did nothing. Recently I wrote an article about 'semantic documentation' that boils down to the concept of getting the correct API docs when replacing the commonly used 'api' subdomain with 'doc'. So, wouldn't it be useful, in addition to pushState, to let the UI show documentation based on its route? E.g. let |
As far as I remember that was working some time ago. On 9 January 2016 at 15:48, Thom van Kalkeren notifications@github.com
Krzysztof Madejski |
This was fixed in 2.1.4. If you try that version, you should see it working fine. It was broken in master for a bit. |
Will be covered by #2884 (ignore the misleading title). |
http://stackoverflow.com/a/10355561
I still have problems with hashbangs being accumulated if SwaggerUI is not hosted on root url (/).
The text was updated successfully, but these errors were encountered: