Cannot find module querystring-browser

[benjdlambert]

Q&A (please complete the following information)

• OS: [e.g. macOS]
• Browser: [e.g. chrome, safari]
• Version: [e.g. 22]
• Method of installation: [e.g. npm, dist assets] yarn
• Swagger-UI version: [e.g. 3.10.0] - 4.0.0rc
• Swagger/OpenAPI version: [e.g. Swagger 2.0, OpenAPI 3.0]

Content & configuration

Module not found: Error: Can't resolve 'querystring-browser' in '/tmp/backstage-e2e-fvJBjP/test-app/node_modules/swagger-ui-react'

Looks like due to the 3.17.0 release of swagger-client which removed the querystring-browser dependency, this module fails to build with the latest stuff.

Had to force to use the older 3.16.0 of swagger-client to get this to work.

[robertgorecki]

+1, same problem here, error "Cannot find module: 'querystring-browser'. Make sure this package is installed." with "swagger-ui-react@3.52.4"

[mathis-m]

@char0n have a look at this! Probably due to the buffer PR.

[paztis]

swagger-ui-react has no dependency to querystring-browser
it has a nested dependency to it through swagger-client, but swagger client jt remove it few days ago

[mathis-m]

Ref swagger-api/swagger-js#2288

[robertgorecki]

Seems to be fixed now with "swagger-ui-react@3.52.5" where dependency on "swagger-client" was upgraded.

[char0n]

Hello all,

This is a repeated problem between swagger-ui and swagger-client. It happens whenever we remove some library from swagger-client. The primary cause of this is the way how we create release fragments with webpack for swagger-ui. We plan to remedy this in near future.

For now, please update to the latest version of swagger-ui: swagger-ui@3.52.5 or swagger-ui@4.0.0-rc.4 which makes this problem go away. If you cannot update for any reason, pin the swagger-client to any version before 3.17.0 as suggested in issue description.

[kaiyoma]

I'm seeing a much more serious version of this problem, even after upgrading to 3.52.5. That version does indeed fix the issues with querystring-browser, but there are still about half a dozen more dependencies with the same issue.

To repro:

1. Start with a webpack project that uses swagger-ui-react
2. Use pnpm link to link an external package (the package doesn't even have to be related to swagger)
3. Start the webpack dev server

At this point, I get a bunch of errors about missing packages. These errors don't appear when I don't use the linking mechanism. Here's what I'm seeing:

ERROR in ./node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react/swagger-ui.js
Module not found: Error: Can't resolve 'autolinker' in '.../node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react'

ERROR in ./node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react/swagger-ui.js
Module not found: Error: Can't resolve 'btoa' in '.../node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react'

ERROR in ./node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react/swagger-ui.js
Module not found: Error: Can't resolve 'fast-json-patch' in '.../node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react'

ERROR in ./node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react/swagger-ui.js
Module not found: Error: Can't resolve 'formdata-node' in '.../node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react'

ERROR in ./node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react/swagger-ui.js
Module not found: Error: Can't resolve 'isarray' in '.../node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react'

ERROR in ./node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react/swagger-ui.js
Module not found: Error: Can't resolve 'qs' in '.../node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react'

ERROR in ./node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react/swagger-ui.js
Module not found: Error: Can't resolve 'traverse' in '.../node_modules/.pnpm/swagger-ui-react@3.52.5_react-dom@16.14.0+react@16.14.0/node_modules/swagger-ui-react'

It would appear that the following are not being set up correctly as dependencies:

1. autolinker
2. btoa
3. fast-json-patch
4. formdata-node
5. isarray
6. qs
7. traverse

[char0n]

Hi @kaiyoma,

First thing I've noticed is that you're using pnpm. Unfortunately we don't test against it and we have no idea how swagger-ui-react behaves when installed via pnpm. We recomment to use standard npm.

I thus cannot reproduce errors that you're seeing. I've put together a repository with minimal webpack@5 setup using swagger-ui-react and I was able to compile successfully without any errors.

Repo: https://github.com/char0n/minimal-react-webpack-babel-setup

Repo uses swagger-ui-react@3.52.5 which comes with swagger-client@3.17.0. Everything compiles without errors and works as expected.

I assume you might have problems with your local setup.

[char0n]

Closing this for now. If any additional problems arise, please reopen.

[JeremyKennedy]

I can confirm that the 7 missing dependencies mentioned above are an issue when using the PnP feature of Yarn 2. I was able to fix it by repeatedly running yarn add with the dependencies reported as missing.

[kaiyoma]

Sounds like something about swagger doesn't work correctly with next-generation package managers.