feat: switch buffer to native Uint8Array

[char0n]

This is followup for #2243.

This is technically not a breaking change as we already claim for long time that minimum version of Node.js is 12.4.

Types of changes

• No code changes (changes to documentation, CI, metadata, etc)
• Dependency changes (any modification to dependencies in package.json)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[char0n]

@jimmywarting please have a look at this PR. It tries to eliminate the usage of Buffer entirely.

[char0n]

@mathis-m please have a look at this well if/when you have time please. Thanks!

[mathis-m]

Looks good for what is the Fallback?

[char0n]

@mathis-m good point. I've added explicit explanation for it as a JSDOC of fallback

/**
 * This is a webpack@5 fallback for `buffer` library.
 * swagger-js is using `querystring-browser` which depends on
 * `buffer` under the hood. The usage is compatible with
 * `Uint8Array` interface though.
 *
 * If we introduce other libraries in future that will depend on
 * `buffer`, this fallback needs to be reviewed again.
 */

[jimmywarting]

lgtm

[char0n]

Thanks guys.

I've just pushed a commit which eliminates the fallback as it will cause problems for library consumers. I've replaced the querystring-browser library with native calls to UrlSearchParams which is suggested by Node.js documentation as querystring API is now deprecated.

[swagger-bot]

🎉 This PR is included in version 3.17.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀