Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

housekeeping: xml -> @kyleshockey/xml #4985

Merged
merged 1 commit into from
Nov 1, 2018
Merged

housekeeping: xml -> @kyleshockey/xml #4985

merged 1 commit into from
Nov 1, 2018

Conversation

shockey
Copy link
Contributor

@shockey shockey commented Oct 31, 2018 •
edited
Loading

This PR migrates Swagger UI to using my browser-compatible fork of xml.

Addresses (likely fixes) #4971.

Bonus: this fixes a logical error I made in #4984 - webpack-dev-server is now actually in devDependencies.

@shockey shockey changed the title xml -> @kyleshockey/xml housekeeping: xml -> @kyleshockey/xml Oct 31, 2018
@shockey
Copy link
Contributor Author

shockey commented Oct 31, 2018

please build

@shockey
Copy link
Contributor Author

shockey commented Nov 1, 2018

please build

3 similar comments
@shockey
Copy link
Contributor Author

shockey commented Nov 1, 2018

please build

@JonathanParrilla
Copy link
Contributor

please build

@JonathanParrilla
Copy link
Contributor

please build

@shockey shockey merged commit b930021 into master Nov 1, 2018
@shockey shockey mentioned this pull request Nov 1, 2018
Closed
@shockey shockey deleted the bug/4971 branch November 26, 2018 14:16
@LittleBaiBai LittleBaiBai mentioned this pull request Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shockey @JonathanParrilla