Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance parameter validation #6878

Merged
merged 4 commits into from
Feb 3, 2021

Conversation

mathis-m
Copy link
Contributor

@mathis-m mathis-m commented Jan 30, 2021

Description

array:
validate min / max items https://swagger.io/docs/specification/data-models/data-types/#array-length
validate uniqueItems #6879
validate items itself(deep)

Object:
validate properties itself(deep)
validate required properties
todo validate additonal properites

Motivation and Context

Fixes #6879
Fixes #6327
Fixes #6880

How Has This Been Tested?

to be tested

Screenshots (if appropriate):

array:
image
image
image
array deep:
image
image

object:
image
image
deep:
image
image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
@mathis-m mathis-m changed the title feat: support min/max items validation feat: enhance parameter validation Jan 31, 2021
Signed-off-by: mathis-m <mathis.michel@outlook.de>
@tim-lai tim-lai merged commit 5c4dfc2 into swagger-api:master Feb 3, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Feb 3, 2021

@mathis-m PR merged! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants