Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a11y): Add aria-label to controls #7528

Closed
wants to merge 1 commit into from
Closed

feat(a11y): Add aria-label to controls #7528

wants to merge 1 commit into from

Conversation

Sundava
Copy link

@Sundava Sundava commented Sep 28, 2021

Description

Add aria-label attribute to servers select box, based on server URL
Add aria-label attribute to various parameters, based on path method query|body|path param_name

Motivation and Context

Required to comply to accessibility rules for screen readers
Fixes #6512

How Has This Been Tested?

Has been locally tested on Chrome by inspecting the DOM, ran test suite to ensure no regression.
Looking

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Personal comment: I have not yet included the required tests as discussed here, mostly because this being my first PR both in React and in this repo, I wanted to make sure I was going in the right direction before spending more time on it.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: missing labels on controls (text fields, select boxes)
1 participant