Removed star property hack in tachyons-sass via patch-package

[DreierF]

Description

The PR removed the star property hack in the tachyons-sass package and integrates the change via patch-package.

Motivation and Context

The issue is already described in #8243 and #7526. We are running into the same issue when trying to bundle swagger-ui via vite.js, which uses esbuild under the hood which in turn trips over the star property hack. As the upstream fix is very unlikely to ever be merged + published we need another solution. Currently we use pnpm patch on the swagger-ui package to fix the issue on our side, but as that patch is based on the minified code and needs to be updated with every swagger-ui update this is not a very good solution. Also the css source maps get out of sync with such a patch.

How Has This Been Tested?

I executed npm run build and manually verified that the dist/swagger-ui.css to no longer contains *zoom.

Checklist

My PR contains...

• No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
• Dependency changes (any modification to dependencies in package.json)
• Bug fixes (non-breaking change which fixes an issue)
• Improvements (misc. changes to existing features)
• Features (non-breaking change which adds functionality)

My changes...

• are breaking changes to a public API (config options, System API, major UI change, etc).
• are breaking changes to a private API (Redux, component props, utility functions, etc.).
• are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
• are not breaking changes.

Documentation

• My changes do not require a change to the project documentation.
• My changes require a change to the project documentation.
• If yes to above: I have updated the documentation accordingly.

Automated tests

• My changes can not or do not need to be tested.
• My changes can and should be tested by unit and/or integration tests.
• If yes to above: I have added tests to cover my changes.
• If yes to above: I have taken care to cover edge cases in my tests.
• All new and existing tests passed.

[tim-lai]

@DreierF PR merged! Thanks for the contribution!

[truh]

Thank you for the fix, didn't know that patch-package even existed. I think the patch should remove the *zoom: 1; line entirely rather than changing it to zoom: 1;.

The purpose of the star property hack used to be to have CSS properties that only apply to certain, long outdated Internet Explorer versions. https://stackoverflow.com/questions/14927651/what-does-zoom1-do-in-bootstrap

Meanwhile the zoom property is a non-standard CSS property which Mozilla tells us should not be use in production sites. https://developer.mozilla.org/en-US/docs/Web/CSS/zoom

[silverwind]

Indeed, the patch should be updated to just remove the declaration. zoom: 1 is essentially a no-op in CSS, but it's still better to just remove it.