Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

Commit

Permalink
shmem-fix-faulting-into-a-hole-while-its-punched-checkpatch-fixes
Browse files Browse the repository at this point in the history
ERROR: trailing whitespace
torvalds#64: FILE: mm/shmem.c:1243:
+^I * wait on i_mutex to be released if vmf->flags permits, $

WARNING: Missing a blank line after declarations
torvalds#68: FILE: mm/shmem.c:1247:
+		struct shmem_falloc *shmem_falloc;
+		spin_lock(&inode->i_lock);

total: 1 errors, 1 warnings, 92 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

./patches/shmem-fix-faulting-into-a-hole-while-its-punched.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Hugh Dickins <hughd@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and sfrothwell committed Jun 20, 2014
1 parent a2e3b44 commit 3a8295e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion mm/shmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -1240,10 +1240,11 @@ static int shmem_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
* prevent the hole-punch from ever completing: which in turn
* locks writers out with its hold on i_mutex. So refrain from
* faulting pages into the hole while it's being punched, and
* wait on i_mutex to be released if vmf->flags permits,
* wait on i_mutex to be released if vmf->flags permits.
*/
if (unlikely(inode->i_private)) {
struct shmem_falloc *shmem_falloc;

spin_lock(&inode->i_lock);
shmem_falloc = inode->i_private;
if (!shmem_falloc ||
Expand Down

0 comments on commit 3a8295e

Please sign in to comment.