Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdg-shell: use wlr_xdg_{toplevel,popup} #6822

Merged
merged 2 commits into from
Feb 7, 2022
Merged

xdg-shell: use wlr_xdg_{toplevel,popup} #6822

merged 2 commits into from
Feb 7, 2022

Conversation

emersion
Copy link
Member

@emersion emersion commented Feb 7, 2022

Improved type safety.

Closes: #6813

cc @vyivel

@vyivel vyivel mentioned this pull request Feb 7, 2022
Closed
vyivel
vyivel approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@vyivel vyivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; it's much cleaner now, and storing the underlying object directly helps to avoid accidental NULL dereference when working with "inert" views, which should fix #6817.
Thanks!

@vyivel vyivel merged commit 9a6687e into swaywm:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyivel vyivel vyivel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xdg-shell: use wlr_xdg_toplevel in views instead of wlr_xdg_surface
2 participants
@emersion @vyivel