Fix damage-ring bounds not being set when unplugging -> plugging in monitor

[ErikReider]

#7524 was a partial fix. Seems like this is still an issue when unplugging and plugging the monitor back in.

I'm not sure if it's a good fix due to the update_output_manager_config function being called from other places though.

[ErikReider]

According to @quoing, this fixes #7528. Should I undo the changes in ac1ed63 and use this instead?

[emersion]

Does it fix the bug to add | WLR_OUTPUT_STATE_ENABLED to this line instead?

sway/sway/desktop/output.c

Line 931 in 9cf66e8

if (event->committed & (WLR_OUTPUT_STATE_MODE | WLR_OUTPUT_STATE_TRANSFORM)) {

[ErikReider]

Does it fix the bug to add | WLR_OUTPUT_STATE_ENABLED to this line instead?

It sadly doesn't

[emersion]

Well, I don't think update_output_manager_config() is a good place to do this. One would need to figure out which of the call sites fixes the issue.

[ErikReider]

Well, I don't think update_output_manager_config() is a good place to do this. One would need to figure out which of the call sites fixes the issue.

I should have time to debug later tonight :)

[quoing]

Could we rollback the original commit that actually broke this thing - or did it fix something else for majority of users? At this point I have to ignore any updates for sway-git or build sway manually (while rolling back the problematic commit).. I'm of course open to check fixes in separate devel branch in case something needs to be tested :)

[ErikReider]

It's this call that's the caller.

sway/sway/desktop/output.c

Line 1030 in 9cf66e8

update_output_manager_config(server);

Fixed in the latest commit

[ErikReider]

Could we rollback the original commit that actually broke this thing - or did it fix something else for majority of users?

I was experiencing integer overflows when trying to expand the damage when working on adding blur in SwayFX, so probably nothing that anyone else experienced :)

Does the latest commit still fix the issue @quoing?

[emersion]

LGTM!

[quoing]

tested the commit and it fixes my issue #7528 ..

~ swaymsg -t get_version
sway version 1.9-dev-fa4aa79c (Apr  6 2023, branch 'makepkg')

[emersion]

Thanks!