Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the DesktopNames key to the sway.desktop session file #7952

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nilninull
Copy link

According to
https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html, to set the value of XDG_CURRENT_DESKTOP, a DesktopNames key is required in the session file. And the value of XDG_CURRENT_DESKTOP is used to run xdg-desktop-portal*.

If this value is not set, xdg-desktop-portal-wlr will not run at login.

The value of XDG_CURRENT_DESKTOP is set by the login manager, but from my research, some of them are supported and some are not.

In sddm, I confirmed that it is supported.

According to
https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html,
to set the value of XDG_CURRENT_DESKTOP, a DesktopNames key is
required in the session file.  And the value of XDG_CURRENT_DESKTOP is
used to run xdg-desktop-portal*.  If this value is not set,
xdg-desktop-portal-wlr will not run at login.
@kennylevinsen
Copy link
Member

Duplicate of:

With the new portal configuration system I'm more open to this. Clients that use this for anything is still horrible, but the .desktop file doesn't change anything there seeing that pretty much everyone runs portals these days and therefore has XDG_CURRENT_DESKTOP set regardless...

@emersion
Copy link
Member

emersion commented Feb 5, 2024

Agreed.

@nilninull
Copy link
Author

OK

@nilninull nilninull closed this Feb 5, 2024
@emersion emersion reopened this Feb 5, 2024
@emersion
Copy link
Member

emersion commented Feb 5, 2024

We've just said that we are "more open to this", which means we are open to the idea!

@DarkDefender
Copy link
Contributor

Is there anything holding this up?

@Vladimir-csp

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants