Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Added cli-config-file option. #20

Merged
merged 3 commits into from
Feb 22, 2024
Merged

feat(cli): Added cli-config-file option. #20

merged 3 commits into from
Feb 22, 2024

Conversation

ShogunPanda
Copy link
Contributor

@ShogunPanda ShogunPanda commented Feb 6, 2024

This PR add a new option that can point to JSON file.
This file can contain any option supported by CLI (either in kebab-case or camelCase format) and will applied accordingly.
Other options explicitly provided via command line override the one in the JSON file (so that the file can act as a "template").

Fixes swc-project/cli#284

Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: 25bf228

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swc/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Feb 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/commander@8.3.0 environment, filesystem, shell 0 151 kB abetomo

🚮 Removed packages: npm/commander@7.1.0

View full report↗︎

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I'm against this feature

@ShogunPanda
Copy link
Contributor Author

That is totally legit, no problem.
Do you mind to elaborate a little bit so we can find eventually a way to both be happy about it?

@kdy1
Copy link
Member

kdy1 commented Feb 7, 2024

Ah, sorry. I thought you added fields to .swcrc, but it was a separate file. I'll review/merge after finishing some tasks in my hand.

@kdy1 kdy1 self-assigned this Feb 7, 2024
@ShogunPanda
Copy link
Contributor Author

No worries, no issues at all.
Keep me posted!

@kdy1
Copy link
Member

kdy1 commented Feb 13, 2024

Can you fix CI?

@ShogunPanda
Copy link
Contributor Author

I tried on my Win machine and did not fail. Do you mind retrying here just in case?

@ShogunPanda
Copy link
Contributor Author

@kdy1 Any update on this?

@kdy1
Copy link
Member

kdy1 commented Feb 22, 2024

I retried CI several times but it still fails

@ShogunPanda
Copy link
Contributor Author

Sorry, my bad. I ran it on the wrong branch. I was able to reproduce, fixing it.

@ShogunPanda
Copy link
Contributor Author

Solved. :)

kdy1
kdy1 previously approved these changes Feb 22, 2024
@kdy1 kdy1 enabled auto-merge (squash) February 22, 2024 23:40
@kdy1 kdy1 merged commit 4c08bf8 into swc-project:main Feb 22, 2024
11 checks passed
kdy1 added a commit that referenced this pull request Oct 22, 2024
kdy1 added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Provide CLI options via file
2 participants