fix(es/minifier): Abort seq inliner if b can short-circuit (#8128)

**Related issue:**

 - Closes #8119

crates/swc/tests/exec/issues-8xxx/8119/.swcrc

@@ -0,0 +1,65 @@
+{
+    "jsc": {
+        "parser": {
+            "syntax": "ecmascript",
+            "jsx": false
+        },
+        "target": "es2022",
+        "loose": false,
+        "minify": {
+            "compress": {
+                "arguments": false,
+                "arrows": true,
+                "booleans": true,
+                "booleans_as_integers": false,
+                "collapse_vars": true,
+                "comparisons": true,
+                "computed_props": true,
+                "conditionals": true,
+                "dead_code": true,
+                "directives": true,
+                "drop_console": false,
+                "drop_debugger": true,
+                "evaluate": true,
+                "expression": false,
+                "hoist_funs": false,
+                "hoist_props": true,
+                "hoist_vars": false,
+                "if_return": true,
+                "join_vars": true,
+                "keep_classnames": false,
+                "keep_fargs": true,
+                "keep_fnames": false,
+                "keep_infinity": false,
+                "loops": true,
+                "negate_iife": true,
+                "properties": true,
+                "reduce_funcs": false,
+                "reduce_vars": false,
+                "side_effects": true,
+                "switches": true,
+                "typeofs": true,
+                "unsafe": false,
+                "unsafe_arrows": false,
+                "unsafe_comps": false,
+                "unsafe_Function": false,
+                "unsafe_math": false,
+                "unsafe_symbols": false,
+                "unsafe_methods": false,
+                "unsafe_proto": false,
+                "unsafe_regexp": false,
+                "unsafe_undefined": false,
+                "unused": true,
+                "const_to_let": true,
+                "pristine_globals": true,
+                "passes": 2
+            },
+            "mangle": false
+        }
+    },
+    "module": {
+        "type": "es6"
+    },
+    "minify": false,
+    "isModule": true
+}

crates/swc/tests/exec/issues-8xxx/8119/1/exec.js

@@ -0,0 +1,24 @@
+const myArr = [];
+// function with side effect
+function foo(arr) {
+    arr.push('foo');
+    return 'foo';
+}
+let a;
+
+if (Math.random() > 1.00000) {
+    a = true;
+}
+
+// the function call below should always run
+// regardless of whether `a` is `undefined`
+let b = foo(myArr);
+
+// const seems to keep this line here instead of
+// moving it behind the logitcal nullish assignment
+// const b = foo(myArr);
+
+a ??= b;
+
+console.log(a);
+console.log(myArr);

crates/swc/tests/exec/issues-8xxx/8119/2/exec.js

@@ -0,0 +1,24 @@
+const myArr = [];
+// function with side effect
+function foo(arr) {
+    arr.push('foo');
+    return 'foo';
+}
+let a;
+
+if (Math.random() > -0.1) {
+    a = true;
+}
+
+// the function call below should always run
+// regardless of whether `a` is `undefined`
+let b = foo(myArr);
+
+// const seems to keep this line here instead of
+// moving it behind the logitcal nullish assignment
+// const b = foo(myArr);
+
+a ??= b;
+
+console.log(a);
+console.log(myArr);

crates/swc/tests/fixture/issues-8xxx/8119/input/.swcrc

@@ -0,0 +1,65 @@
+{
+    "jsc": {
+        "parser": {
+            "syntax": "ecmascript",
+            "jsx": false
+        },
+        "target": "es2022",
+        "loose": false,
+        "minify": {
+            "compress": {
+                "arguments": false,
+                "arrows": true,
+                "booleans": true,
+                "booleans_as_integers": false,
+                "collapse_vars": true,
+                "comparisons": true,
+                "computed_props": true,
+                "conditionals": true,
+                "dead_code": true,
+                "directives": true,
+                "drop_console": false,
+                "drop_debugger": true,
+                "evaluate": true,
+                "expression": false,
+                "hoist_funs": false,
+                "hoist_props": true,
+                "hoist_vars": false,
+                "if_return": true,
+                "join_vars": true,
+                "keep_classnames": false,
+                "keep_fargs": true,
+                "keep_fnames": false,
+                "keep_infinity": false,
+                "loops": true,
+                "negate_iife": true,
+                "properties": true,
+                "reduce_funcs": false,
+                "reduce_vars": false,
+                "side_effects": true,
+                "switches": true,
+                "typeofs": true,
+                "unsafe": false,
+                "unsafe_arrows": false,
+                "unsafe_comps": false,
+                "unsafe_Function": false,
+                "unsafe_math": false,
+                "unsafe_symbols": false,
+                "unsafe_methods": false,
+                "unsafe_proto": false,
+                "unsafe_regexp": false,
+                "unsafe_undefined": false,
+                "unused": true,
+                "const_to_let": true,
+                "pristine_globals": true,
+                "passes": 2
+            },
+            "mangle": false
+        }
+    },
+    "module": {
+        "type": "es6"
+    },
+    "minify": false,
+    "isModule": true
+}

crates/swc/tests/fixture/issues-8xxx/8119/input/1.js

@@ -0,0 +1,24 @@
+const myArr = [];
+// function with side effect
+function foo(arr) {
+    arr.push('foo');
+    return 'foo';
+}
+let a;
+
+if (Math.random() > 0.5) {
+    a = true;
+}
+
+// the function call below should always run
+// regardless of whether `a` is `undefined`
+let b = foo(myArr);
+
+// const seems to keep this line here instead of
+// moving it behind the logitcal nullish assignment
+// const b = foo(myArr);
+
+a ??= b;
+
+console.log(a);
+console.log(myArr);

crates/swc/tests/fixture/issues-8xxx/8119/output/1.js

@@ -0,0 +1,10 @@
+let a;
+const myArr = [];
+Math.random() > 0.5 && (a = !0);
+// the function call below should always run
+// regardless of whether `a` is `undefined`
+let b = (myArr.push('foo'), 'foo');
+console.log(// const seems to keep this line here instead of
+// moving it behind the logitcal nullish assignment
+// const b = foo(myArr);
+a ??= b), console.log(myArr);

crates/swc_ecma_minifier/src/compress/optimize/sequences.rs

@@ -2489,6 +2489,10 @@ impl Optimizer<'_> {
     /// 1, arr[i]`
     //
     fn should_not_check_rhs_of_assign(&self, a: &Mergable, b: &mut AssignExpr) -> Result<bool, ()> {
+        if b.op.may_short_circuit() {
+            return Ok(true);
+        }
+
         if let Some(a_id) = a.id() {
             match a {
                 Mergable::Expr(Expr::Assign(AssignExpr { op: op!("="), .. })) => {}