fix(es/minifier): Fix undefined judgement (#9146)

**Description:**

by symbol name -> by whether it points to global undefined or not.

The updated test results all involve variables with `undefined` ident (although they are indeed uninitialized).


**Related issue:**

 - Closes: #8567

crates/swc/tests/tsc-references/fixSignatureCaching.2.minified.js

@@ -376,13 +376,13 @@ import { _ as _instanceof } from "@swc/helpers/_/_instanceof";
             return impl.prepareDetectionCache(this._cache, this.ua, this.maxPhoneWidth), this._cache.tablet;
         },
         userAgent: function() {
-            return undefined === this._cache.userAgent && (this._cache.userAgent = impl.findMatch(impl.mobileDetectRules.uas, this.ua)), this._cache.userAgent;
+            return this._cache.userAgent === undefined && (this._cache.userAgent = impl.findMatch(impl.mobileDetectRules.uas, this.ua)), this._cache.userAgent;
         },
         userAgents: function() {
-            return undefined === this._cache.userAgents && (this._cache.userAgents = impl.findMatches(impl.mobileDetectRules.uas, this.ua)), this._cache.userAgents;
+            return this._cache.userAgents === undefined && (this._cache.userAgents = impl.findMatches(impl.mobileDetectRules.uas, this.ua)), this._cache.userAgents;
         },
         os: function() {
-            return undefined === this._cache.os && (this._cache.os = impl.detectOS(this.ua)), this._cache.os;
+            return this._cache.os === undefined && (this._cache.os = impl.detectOS(this.ua)), this._cache.os;
         },
         version: function(key) {
             return impl.getVersion(key, this.ua);
@@ -400,7 +400,7 @@ import { _ as _instanceof } from "@swc/helpers/_/_instanceof";
             return MobileDetect.isPhoneSized(maxPhoneWidth || this.maxPhoneWidth);
         },
         mobileGrade: function() {
-            return undefined === this._cache.grade && (this._cache.grade = impl.mobileGrade(this)), this._cache.grade;
+            return this._cache.grade === undefined && (this._cache.grade = impl.mobileGrade(this)), this._cache.grade;
         }
     }, 'undefined' != typeof window && window.screen ? MobileDetect.isPhoneSized = function(maxPhoneWidth) {
         return maxPhoneWidth < 0 ? undefined : impl.getDeviceSmallerSide() <= maxPhoneWidth;

crates/swc_ecma_minifier/src/compress/util/mod.rs

@@ -378,15 +378,13 @@ pub(crate) fn negate_cost(
 
 pub(crate) fn is_pure_undefined(expr_ctx: &ExprCtx, e: &Expr) -> bool {
     match e {
-        Expr::Ident(Ident { sym, .. }) if &**sym == "undefined" => true,
-
         Expr::Unary(UnaryExpr {
             op: UnaryOp::Void,
             arg,
             ..
         }) if !arg.may_have_side_effects(expr_ctx) => true,
 
-        _ => false,
+        _ => e.is_undefined(expr_ctx),
     }
 }
 

crates/swc_ecma_minifier/tests/benches-full/lodash.js

@@ -723,7 +723,7 @@
             return hasOwnProperty.call(data, key) ? data[key] : undefined;
         }, Hash.prototype.has = function(key) {
             var data = this.__data__;
-            return nativeCreate ? undefined !== data[key] : hasOwnProperty.call(data, key);
+            return nativeCreate ? data[key] !== undefined : hasOwnProperty.call(data, key);
         }, Hash.prototype.set = function(key, value) {
             var data = this.__data__;
             return this.size += this.has(key) ? 0 : 1, data[key] = nativeCreate && undefined === value ? HASH_UNDEFINED : value, this;
@@ -1546,7 +1546,7 @@
                     }
                     (value = source[5]) && (partials = data[5], data[5] = partials ? composeArgsRight(partials, value, source[6]) : value, data[6] = partials ? replaceHolders(data[5], PLACEHOLDER) : source[6]), (value = source[7]) && (data[7] = value), 128 & srcBitmask && (data[8] = null == data[8] ? source[8] : nativeMin(data[8], source[8])), null == data[9] && (data[9] = source[9]), data[0] = source[0], data[1] = newBitmask;
                 }
-            }(newData, data), func = newData[0], bitmask = newData[1], thisArg = newData[2], partials = newData[3], holders = newData[4], (arity = newData[9] = undefined === newData[9] ? isBindKey ? 0 : func.length : nativeMax(newData[9] - length, 0)) || !(24 & bitmask) || (bitmask &= -25), bitmask && 1 != bitmask) 8 == bitmask || 16 == bitmask ? (func1 = func, bitmask1 = bitmask, arity1 = arity, Ctor = createCtor(func1), result = function wrapper() {
+            }(newData, data), func = newData[0], bitmask = newData[1], thisArg = newData[2], partials = newData[3], holders = newData[4], (arity = newData[9] = newData[9] === undefined ? isBindKey ? 0 : func.length : nativeMax(newData[9] - length, 0)) || !(24 & bitmask) || (bitmask &= -25), bitmask && 1 != bitmask) 8 == bitmask || 16 == bitmask ? (func1 = func, bitmask1 = bitmask, arity1 = arity, Ctor = createCtor(func1), result = function wrapper() {
                 for(var length = arguments.length, args = Array1(length), index = length, placeholder = getHolder(wrapper); index--;)args[index] = arguments[index];
                 var holders = length < 3 && args[0] !== placeholder && args[length - 1] !== placeholder ? [] : replaceHolders(args, placeholder);
                 return (length -= holders.length) < arity1 ? createRecurry(func1, bitmask1, createHybrid, wrapper.placeholder, undefined, args, holders, undefined, undefined, arity1 - length) : apply(this && this !== root && this instanceof wrapper ? Ctor : func1, this, args);
@@ -3061,7 +3061,7 @@
         }, lodash.prototype.commit = function() {
             return new LodashWrapper(this.value(), this.__chain__);
         }, lodash.prototype.next = function() {
-            undefined === this.__values__ && (this.__values__ = toArray(this.value()));
+            this.__values__ === undefined && (this.__values__ = toArray(this.value()));
             var done = this.__index__ >= this.__values__.length, value = done ? undefined : this.__values__[this.__index__++];
             return {
                 done: done,

crates/swc_ecma_minifier/tests/fixture/issues/8567/input.js

@@ -0,0 +1,5 @@
+const templatePath = () => {
+    const undefined = "lol1";
+    return undefined;
+};
+console.log(templatePath());

crates/swc_ecma_minifier/tests/fixture/issues/8567/output.js

@@ -0,0 +1 @@
+console.log("lol1");

crates/swc_ecma_minifier/tests/projects/output/angular-1.2.5.js

@@ -171,7 +171,7 @@
                     if (!equals(o1[key], o2[key])) return !1;
                     keySet[key] = !0;
                 }
-                for(key in o2)if (!keySet.hasOwnProperty(key) && "$" !== key.charAt(0) && undefined !== o2[key] && !isFunction(o2[key])) return !1;
+                for(key in o2)if (!keySet.hasOwnProperty(key) && "$" !== key.charAt(0) && o2[key] !== undefined && !isFunction(o2[key])) return !1;
                 return !0;
             }
         }
@@ -199,7 +199,7 @@
         return "string" == typeof key && "$" === key.charAt(0) ? val = undefined : isWindow(value) ? val = "$WINDOW" : value && document1 === value ? val = "$DOCUMENT" : isScope(value) && (val = "$SCOPE"), val;
     }
     function toJson(obj, pretty) {
-        if (void 0 !== obj) return JSON.stringify(obj, toJsonReplacer, pretty ? "  " : null);
+        return void 0 === obj ? undefined : JSON.stringify(obj, toJsonReplacer, pretty ? "  " : null);
     }
     function fromJson(json) {
         return isString(json) ? JSON.parse(json) : json;
@@ -440,7 +440,7 @@
         for(var names = isArray(name) ? name : [
             name
         ]; element.length;){
-            for(var i = 0, ii = names.length; i < ii; i++)if (undefined !== (value = element.data(names[i]))) return value;
+            for(var i = 0, ii = names.length; i < ii; i++)if ((value = element.data(names[i])) !== undefined) return value;
             element = element.parent();
         }
     }
@@ -939,7 +939,7 @@
             var cookieLength, cookieArray, cookie, i, index;
             if (name) undefined === value ? rawDocument.cookie = escape(name) + "=;path=" + cookiePath + ";expires=Thu, 01 Jan 1970 00:00:00 GMT" : isString(value) && (cookieLength = (rawDocument.cookie = escape(name) + "=" + escape(value) + ";path=" + cookiePath).length + 1) > 4096 && $log.warn("Cookie '" + name + "' possibly not set or overflowed because it was too large (" + cookieLength + " > 4096 bytes)!");
             else {
-                if (rawDocument.cookie !== lastCookieString) for(i = 0, cookieArray = (lastCookieString = rawDocument.cookie).split("; "), lastCookies = {}; i < cookieArray.length; i++)(index = (cookie = cookieArray[i]).indexOf("=")) > 0 && undefined === lastCookies[name = unescape(cookie.substring(0, index))] && (lastCookies[name] = unescape(cookie.substring(index + 1)));
+                if (rawDocument.cookie !== lastCookieString) for(i = 0, cookieArray = (lastCookieString = rawDocument.cookie).split("; "), lastCookies = {}; i < cookieArray.length; i++)(index = (cookie = cookieArray[i]).indexOf("=")) > 0 && lastCookies[name = unescape(cookie.substring(0, index))] === undefined && (lastCookies[name] = unescape(cookie.substring(index + 1)));
                 return lastCookies;
             }
         }, self.defer = function(fn, delay) {
@@ -1847,7 +1847,7 @@
             this.$$url = encodePath(this.$$path) + (search ? "?" + search : "") + hash, this.$$absUrl = appBaseNoFile + this.$$url.substr(1);
         }, this.$$rewrite = function(url) {
             var appUrl, prevAppUrl;
-            return undefined !== (appUrl = beginsWith(appBase, url)) ? (prevAppUrl = appUrl, undefined !== (appUrl = beginsWith(basePrefix, appUrl))) ? appBaseNoFile + (beginsWith("/", appUrl) || appUrl) : appBase + prevAppUrl : undefined !== (appUrl = beginsWith(appBaseNoFile, url)) ? appBaseNoFile + appUrl : appBaseNoFile == url + "/" ? appBaseNoFile : void 0;
+            return (appUrl = beginsWith(appBase, url)) !== undefined ? (prevAppUrl = appUrl, (appUrl = beginsWith(basePrefix, appUrl)) !== undefined) ? appBaseNoFile + (beginsWith("/", appUrl) || appUrl) : appBase + prevAppUrl : (appUrl = beginsWith(appBaseNoFile, url)) !== undefined ? appBaseNoFile + appUrl : appBaseNoFile == url + "/" ? appBaseNoFile : void 0;
         };
     }
     function LocationHashbangUrl(appBase, hashPrefix) {
@@ -2246,7 +2246,7 @@
                 promise.then(function(val) {
                     promise.$$v = val;
                 });
-            }(obj), undefined === obj.$$v && (obj.$$v = {}), obj = obj.$$v);
+            }(obj), obj.$$v === undefined && (obj.$$v = {}), obj = obj.$$v);
         }
         return obj[key = ensureSafeMemberName(element.shift(), fullExp)] = setValue, setValue;
     }
@@ -2403,9 +2403,9 @@
             var parser = this, indexFn = this.expression();
             return this.consume("]"), extend(function(self, locals) {
                 var v, p, o = obj(self, locals), i = indexFn(self, locals);
-                if (o) return (v = ensureSafeObject(o[i], parser.text)) && v.then && parser.options.unwrapPromises && (p = v, "$$v" in v || (p.$$v = undefined, p.then(function(val) {
+                return o ? ((v = ensureSafeObject(o[i], parser.text)) && v.then && parser.options.unwrapPromises && (p = v, "$$v" in v || (p.$$v = undefined, p.then(function(val) {
                     p.$$v = val;
-                })), v = v.$$v), v;
+                })), v = v.$$v), v) : undefined;
             }, {
                 assign: function(self, value, locals) {
                     var key = indexFn(self, locals);
@@ -3488,44 +3488,38 @@
         number: function(scope, element, attr, ctrl, $sniffer, $browser) {
             if (textInputType(scope, element, attr, ctrl, $sniffer, $browser), ctrl.$parsers.push(function(value) {
                 var empty = ctrl.$isEmpty(value);
-                if (empty || NUMBER_REGEXP.test(value)) return ctrl.$setValidity("number", !0), "" === value ? null : empty ? value : parseFloat(value);
-                ctrl.$setValidity("number", !1);
+                return empty || NUMBER_REGEXP.test(value) ? (ctrl.$setValidity("number", !0), "" === value ? null : empty ? value : parseFloat(value)) : (ctrl.$setValidity("number", !1), undefined);
             }), ctrl.$formatters.push(function(value) {
                 return ctrl.$isEmpty(value) ? "" : "" + value;
             }), attr.min) {
                 var minValidator = function(value) {
                     var min = parseFloat(attr.min);
-                    if (ctrl.$isEmpty(value) || !(value < min)) return ctrl.$setValidity("min", !0), value;
-                    ctrl.$setValidity("min", !1);
+                    return !ctrl.$isEmpty(value) && value < min ? (ctrl.$setValidity("min", !1), undefined) : (ctrl.$setValidity("min", !0), value);
                 };
                 ctrl.$parsers.push(minValidator), ctrl.$formatters.push(minValidator);
             }
             if (attr.max) {
                 var maxValidator = function(value) {
                     var max = parseFloat(attr.max);
-                    if (ctrl.$isEmpty(value) || !(value > max)) return ctrl.$setValidity("max", !0), value;
-                    ctrl.$setValidity("max", !1);
+                    return !ctrl.$isEmpty(value) && value > max ? (ctrl.$setValidity("max", !1), undefined) : (ctrl.$setValidity("max", !0), value);
                 };
                 ctrl.$parsers.push(maxValidator), ctrl.$formatters.push(maxValidator);
             }
             ctrl.$formatters.push(function(value) {
-                if (ctrl.$isEmpty(value) || isNumber(value)) return ctrl.$setValidity("number", !0), value;
-                ctrl.$setValidity("number", !1);
+                return ctrl.$isEmpty(value) || isNumber(value) ? (ctrl.$setValidity("number", !0), value) : (ctrl.$setValidity("number", !1), undefined);
             });
         },
         url: function(scope, element, attr, ctrl, $sniffer, $browser) {
             textInputType(scope, element, attr, ctrl, $sniffer, $browser);
             var urlValidator = function(value) {
-                if (ctrl.$isEmpty(value) || URL_REGEXP.test(value)) return ctrl.$setValidity("url", !0), value;
-                ctrl.$setValidity("url", !1);
+                return ctrl.$isEmpty(value) || URL_REGEXP.test(value) ? (ctrl.$setValidity("url", !0), value) : (ctrl.$setValidity("url", !1), undefined);
             };
             ctrl.$formatters.push(urlValidator), ctrl.$parsers.push(urlValidator);
         },
         email: function(scope, element, attr, ctrl, $sniffer, $browser) {
             textInputType(scope, element, attr, ctrl, $sniffer, $browser);
             var emailValidator = function(value) {
-                if (ctrl.$isEmpty(value) || EMAIL_REGEXP.test(value)) return ctrl.$setValidity("email", !0), value;
-                ctrl.$setValidity("email", !1);
+                return ctrl.$isEmpty(value) || EMAIL_REGEXP.test(value) ? (ctrl.$setValidity("email", !0), value) : (ctrl.$setValidity("email", !1), undefined);
             };
             ctrl.$formatters.push(emailValidator), ctrl.$parsers.push(emailValidator);
         },
@@ -3591,8 +3585,7 @@
             element.val(ctrl.$isEmpty(ctrl.$viewValue) ? "" : ctrl.$viewValue);
         };
         var patternValidator, match, pattern = attr.ngPattern, validate = function(regexp, value) {
-            if (ctrl.$isEmpty(value) || regexp.test(value)) return ctrl.$setValidity("pattern", !0), value;
-            ctrl.$setValidity("pattern", !1);
+            return ctrl.$isEmpty(value) || regexp.test(value) ? (ctrl.$setValidity("pattern", !0), value) : (ctrl.$setValidity("pattern", !1), undefined);
         };
         if (pattern && ((match = pattern.match(/^\/(.*)\/([gim]*)$/)) ? (pattern = new RegExp(match[1], match[2]), patternValidator = function(value) {
             return validate(pattern, value);
@@ -3602,15 +3595,13 @@
             return validate(patternObj, value);
         }, ctrl.$formatters.push(patternValidator), ctrl.$parsers.push(patternValidator)), attr.ngMinlength) {
             var minlength = int(attr.ngMinlength), minLengthValidator = function(value) {
-                if (ctrl.$isEmpty(value) || !(value.length < minlength)) return ctrl.$setValidity("minlength", !0), value;
-                ctrl.$setValidity("minlength", !1);
+                return !ctrl.$isEmpty(value) && value.length < minlength ? (ctrl.$setValidity("minlength", !1), undefined) : (ctrl.$setValidity("minlength", !0), value);
             };
             ctrl.$parsers.push(minLengthValidator), ctrl.$formatters.push(minLengthValidator);
         }
         if (attr.ngMaxlength) {
             var maxlength = int(attr.ngMaxlength), maxLengthValidator = function(value) {
-                if (ctrl.$isEmpty(value) || !(value.length > maxlength)) return ctrl.$setValidity("maxlength", !0), value;
-                ctrl.$setValidity("maxlength", !1);
+                return !ctrl.$isEmpty(value) && value.length > maxlength ? (ctrl.$setValidity("maxlength", !1), undefined) : (ctrl.$setValidity("maxlength", !0), value);
             };
             ctrl.$parsers.push(maxLengthValidator), ctrl.$formatters.push(maxLengthValidator);
         }
@@ -3720,7 +3711,7 @@
                         }), list;
                     }
                 }), ctrl.$formatters.push(function(value) {
-                    if (isArray(value)) return value.join(", ");
+                    return isArray(value) ? value.join(", ") : undefined;
                 }), ctrl.$isEmpty = function(value) {
                     return !value || !value.length;
                 };