fix(es/compat): Add support for destructuring with BigInts (#9215)

**Related issue:** - #9213
swc-project · Jul 12, 2024 · 2cc7028 · 2cc7028
1 parent 524cab0
commit 2cc7028
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/crates/swc/tests/fixture/issues-9xxx/9213/input/.swcrc b/crates/swc/tests/fixture/issues-9xxx/9213/input/.swcrc
@@ -0,0 +1,5 @@
+{
+    "jsc": {
+        "target": "es5"
+    }
+}
diff --git a/crates/swc/tests/fixture/issues-9xxx/9213/input/destruct-bigint.js b/crates/swc/tests/fixture/issues-9xxx/9213/input/destruct-bigint.js
@@ -0,0 +1 @@
+var { 9007199254740991n: it } = { 9007199254740991n: 1 };
diff --git a/crates/swc/tests/fixture/issues-9xxx/9213/output/destruct-bigint.js b/crates/swc/tests/fixture/issues-9xxx/9213/output/destruct-bigint.js
@@ -0,0 +1,3 @@
+var _ref = {
+    9007199254740991n: 1
+}, it = _ref[9007199254740991n];
diff --git a/crates/swc_ecma_compat_es2015/src/destructuring.rs b/crates/swc_ecma_compat_es2015/src/destructuring.rs
@@ -1205,7 +1205,7 @@ fn make_ref_ident_for_array(
 }
 
 fn make_ref_prop_expr(ref_ident: &Ident, prop: Box<Expr>, mut computed: bool) -> Expr {
-    computed |= matches!(*prop, Expr::Lit(Lit::Num(..)) | Expr::Lit(Lit::Str(..)));
+    computed |= !matches!(*prop, Expr::Ident(..));
 
     MemberExpr {
         span: DUMMY_SP,