fix(es/codegen): Accept &impl Node instead of impl Node (#8969)

swc-project · May 23, 2024 · a456799 · a456799
1 parent 85e4eaa
commit a456799
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/crates/swc_ecma_codegen/src/lib.rs b/crates/swc_ecma_codegen/src/lib.rs
@@ -42,7 +42,7 @@ pub type Result = io::Result<()>;
 pub fn to_code_default(
     cm: Lrc<SourceMap>,
     comments: Option<&dyn Comments>,
-    node: impl Node,
+    node: &impl Node,
 ) -> String {
     let mut buf = vec![];
     {
@@ -59,12 +59,12 @@ pub fn to_code_default(
 }
 
 /// Generate a code from a syntax node using default options.
-pub fn to_code_with_comments(comments: Option<&dyn Comments>, node: impl Node) -> String {
+pub fn to_code_with_comments(comments: Option<&dyn Comments>, node: &impl Node) -> String {
     to_code_default(Default::default(), comments, node)
 }
 
 /// Generate a code from a syntax node using default options.
-pub fn to_code(node: impl Node) -> String {
+pub fn to_code(node: &impl Node) -> String {
     to_code_with_comments(None, node)
 }
 

diff --git a/crates/swc_ecma_transforms_typescript/examples/ts_to_js.rs b/crates/swc_ecma_transforms_typescript/examples/ts_to_js.rs
@@ -76,6 +76,6 @@ fn main() {
         // Ensure that we have enough parenthesis.
         let program = module.fold_with(&mut fixer(Some(&comments)));
 
-        println!("{}", to_code_default(cm, Some(&comments), program));
+        println!("{}", to_code_default(cm, Some(&comments), &program));
     })
 }
diff --git a/crates/swc_ecma_transforms_typescript/tests/strip_correctness.rs b/crates/swc_ecma_transforms_typescript/tests/strip_correctness.rs
@@ -124,7 +124,7 @@ fn identity(entry: PathBuf) {
                 Err(_) => return Ok(()),
             };
 
-            to_code_default(cm.clone(), None, program)
+            to_code_default(cm.clone(), None, &program)
         };
 
         println!("---------------- JS ----------------\n\n{}", js_content);