Skip to content

Commit

Permalink
fix(estree/compat): Adjust loc.col (#7565)
Browse files Browse the repository at this point in the history
  • Loading branch information
@kwonoj
kwonoj authored Jun 22, 2023
1 parent 8c1436a commit d86f8f6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/swc_estree_compat/src/babelify/mod.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ impl Context {

Some(LineCol {
line: loc.line,
column: loc.col_display,
column: loc.col.0,
})
}

Expand Down

1 comment on commit d86f8f6

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d86f8f6 Previous: d57d0d3 Ratio
es/full/bugs-1 301294 ns/iter (± 6264) 358587 ns/iter (± 5093) 0.84
es/full/minify/libraries/antd 1485653170 ns/iter (± 19414753) 1875034995 ns/iter (± 17086142) 0.79
es/full/minify/libraries/d3 328290632 ns/iter (± 10975517) 406102356 ns/iter (± 8783646) 0.81
es/full/minify/libraries/echarts 1209673516 ns/iter (± 14546819) 1552261636 ns/iter (± 5716024) 0.78
es/full/minify/libraries/jquery 95916042 ns/iter (± 257158) 119377940 ns/iter (± 1004909) 0.80
es/full/minify/libraries/lodash 114119965 ns/iter (± 528325) 145270166 ns/iter (± 3326158) 0.79
es/full/minify/libraries/moment 56090702 ns/iter (± 178904) 65141456 ns/iter (± 301724) 0.86
es/full/minify/libraries/react 20112096 ns/iter (± 105488) 23375263 ns/iter (± 94894) 0.86
es/full/minify/libraries/terser 248711768 ns/iter (± 1643717) 296888565 ns/iter (± 2774333) 0.84
es/full/minify/libraries/three 442240095 ns/iter (± 3648939) 543486775 ns/iter (± 3062139) 0.81
es/full/minify/libraries/typescript 3016586468 ns/iter (± 35673678) 3486327926 ns/iter (± 40380663) 0.87
es/full/minify/libraries/victory 650606263 ns/iter (± 5513823) 797075868 ns/iter (± 4824516) 0.82
es/full/minify/libraries/vue 138436344 ns/iter (± 685131) 166446310 ns/iter (± 2332866) 0.83
es/full/codegen/es3 38033 ns/iter (± 92) 42723 ns/iter (± 71) 0.89
es/full/codegen/es5 38097 ns/iter (± 89) 42802 ns/iter (± 113) 0.89
es/full/codegen/es2015 38098 ns/iter (± 80) 42802 ns/iter (± 82) 0.89
es/full/codegen/es2016 38181 ns/iter (± 102) 42799 ns/iter (± 112) 0.89
es/full/codegen/es2017 38190 ns/iter (± 132) 42728 ns/iter (± 82) 0.89
es/full/codegen/es2018 38103 ns/iter (± 73) 42779 ns/iter (± 61) 0.89
es/full/codegen/es2019 38152 ns/iter (± 122) 42801 ns/iter (± 115) 0.89
es/full/codegen/es2020 38159 ns/iter (± 83) 42834 ns/iter (± 75) 0.89
es/full/all/es3 178235399 ns/iter (± 1013213) 205427831 ns/iter (± 3530582) 0.87
es/full/all/es5 170733603 ns/iter (± 481092) 197578271 ns/iter (± 1896434) 0.86
es/full/all/es2015 126826614 ns/iter (± 375093) 154256869 ns/iter (± 2906054) 0.82
es/full/all/es2016 126365176 ns/iter (± 464006) 153872932 ns/iter (± 2163147) 0.82
es/full/all/es2017 126283511 ns/iter (± 633773) 153929792 ns/iter (± 3415973) 0.82
es/full/all/es2018 123334056 ns/iter (± 446160) 151661074 ns/iter (± 3398109) 0.81
es/full/all/es2019 123653306 ns/iter (± 670161) 151549783 ns/iter (± 3479461) 0.82
es/full/all/es2020 118821341 ns/iter (± 662972) 147792514 ns/iter (± 2035497) 0.80
es/full/parser 514655 ns/iter (± 5750) 594390 ns/iter (± 8458) 0.87
es/full/base/fixer 18943 ns/iter (± 117) 24725 ns/iter (± 45) 0.77
es/full/base/resolver_and_hygiene 95856 ns/iter (± 803) 105025 ns/iter (± 403) 0.91
serialization of serde 309 ns/iter (± 1) 262 ns/iter (± 4) 1.18
css/minify/libraries/bootstrap 31019763 ns/iter (± 90756) 36774614 ns/iter (± 228457) 0.84
css/visitor/compare/clone 2017156 ns/iter (± 14743) 2391390 ns/iter (± 16730) 0.84
css/visitor/compare/visit_mut_span 2120120 ns/iter (± 9846) 2563216 ns/iter (± 7045) 0.83
css/visitor/compare/visit_mut_span_panic 2202470 ns/iter (± 12292) 2593268 ns/iter (± 20039) 0.85
css/visitor/compare/fold_span 2835515 ns/iter (± 12336) 3322072 ns/iter (± 15527) 0.85
css/visitor/compare/fold_span_panic 3014920 ns/iter (± 10700) 3526204 ns/iter (± 9508) 0.86
css/lexer/bootstrap_5_1_3 4764454 ns/iter (± 5349) 5615925 ns/iter (± 3370) 0.85
css/lexer/foundation_6_7_4 4001886 ns/iter (± 1105) 4717157 ns/iter (± 2526) 0.85
css/lexer/tailwind_3_1_1 756489 ns/iter (± 2369) 898078 ns/iter (± 875) 0.84
css/parser/bootstrap_5_1_3 20741972 ns/iter (± 39755) 24604589 ns/iter (± 122502) 0.84
css/parser/foundation_6_7_4 16675748 ns/iter (± 24512) 19365945 ns/iter (± 71629) 0.86
css/parser/tailwind_3_1_1 3239200 ns/iter (± 4103) 3724132 ns/iter (± 4625) 0.87
es/codegen/colors 737526 ns/iter (± 400510) 739313 ns/iter (± 400771) 1.00
es/codegen/large 2981143 ns/iter (± 1562297) 3109105 ns/iter (± 1609392) 0.96
es/codegen/with-parser/colors 49228 ns/iter (± 185) 56898 ns/iter (± 662) 0.87
es/codegen/with-parser/large 518057 ns/iter (± 1610) 577473 ns/iter (± 3943) 0.90
es/minify/libraries/antd 1316454798 ns/iter (± 13115714) 1630011464 ns/iter (± 11534184) 0.81
es/minify/libraries/d3 279387956 ns/iter (± 1643540) 345226264 ns/iter (± 5265078) 0.81
es/minify/libraries/echarts 1053581685 ns/iter (± 10189167) 1297166292 ns/iter (± 29502356) 0.81
es/minify/libraries/jquery 83788507 ns/iter (± 612981) 104148726 ns/iter (± 1329809) 0.80
es/minify/libraries/lodash 102812781 ns/iter (± 349114) 127152789 ns/iter (± 1933099) 0.81
es/minify/libraries/moment 49135565 ns/iter (± 75856) 59407841 ns/iter (± 869143) 0.83
es/minify/libraries/react 17971984 ns/iter (± 45463) 21376588 ns/iter (± 260932) 0.84
es/minify/libraries/terser 214163955 ns/iter (± 937203) 279701553 ns/iter (± 5746923) 0.77
es/minify/libraries/three 368860912 ns/iter (± 3219180) 469126448 ns/iter (± 6242310) 0.79
es/minify/libraries/typescript 2587366771 ns/iter (± 9918194) 3072003467 ns/iter (± 11925278) 0.84
es/minify/libraries/victory 552900739 ns/iter (± 20826442) 686847046 ns/iter (± 10277117) 0.80
es/minify/libraries/vue 125100884 ns/iter (± 706466) 150486015 ns/iter (± 1655656) 0.83
es/visitor/compare/clone 2071882 ns/iter (± 5724) 2409689 ns/iter (± 8178) 0.86
es/visitor/compare/visit_mut_span 2408184 ns/iter (± 3434) 2788320 ns/iter (± 7505) 0.86
es/visitor/compare/visit_mut_span_panic 2450961 ns/iter (± 4791) 2833410 ns/iter (± 5779) 0.87
es/visitor/compare/fold_span 3481232 ns/iter (± 4901) 3903898 ns/iter (± 5604) 0.89
es/visitor/compare/fold_span_panic 3620643 ns/iter (± 2559) 4046859 ns/iter (± 14218) 0.89
es/lexer/colors 13193 ns/iter (± 69) 14905 ns/iter (± 12) 0.89
es/lexer/angular 6353260 ns/iter (± 3488) 7108231 ns/iter (± 10921) 0.89
es/lexer/backbone 812181 ns/iter (± 1522) 864164 ns/iter (± 22775) 0.94
es/lexer/jquery 4638921 ns/iter (± 6746) 4816916 ns/iter (± 5773) 0.96
es/lexer/jquery mobile 7078528 ns/iter (± 5823) 7452415 ns/iter (± 5081) 0.95
es/lexer/mootools 3655476 ns/iter (± 3519) 3755667 ns/iter (± 4142) 0.97
es/lexer/underscore 683089 ns/iter (± 905) 712355 ns/iter (± 5846) 0.96
es/lexer/three 21574415 ns/iter (± 28963) 22569151 ns/iter (± 21793) 0.96
es/lexer/yui 4065151 ns/iter (± 24041) 4347155 ns/iter (± 4304) 0.94
es/parser/colors 29017 ns/iter (± 166) 33503 ns/iter (± 77) 0.87
es/parser/angular 14201912 ns/iter (± 41433) 16478127 ns/iter (± 116834) 0.86
es/parser/backbone 2110806 ns/iter (± 7950) 2376168 ns/iter (± 15543) 0.89
es/parser/jquery 11512153 ns/iter (± 60269) 12826684 ns/iter (± 95673) 0.90
es/parser/jquery mobile 17749963 ns/iter (± 153871) 19782283 ns/iter (± 317777) 0.90
es/parser/mootools 8825230 ns/iter (± 27637) 9763416 ns/iter (± 29240) 0.90
es/parser/underscore 1818554 ns/iter (± 10901) 2010606 ns/iter (± 9729) 0.90
es/parser/three 49202333 ns/iter (± 389327) 58691351 ns/iter (± 486771) 0.84
es/parser/yui 8898208 ns/iter (± 25624) 9942402 ns/iter (± 73406) 0.89
es/preset-env/usage/builtin_type 143989 ns/iter (± 34051) 149629 ns/iter (± 33769) 0.96
es/preset-env/usage/property 18659 ns/iter (± 55) 27382 ns/iter (± 92) 0.68
es/resolver/typescript 98755894 ns/iter (± 1576737) 119746933 ns/iter (± 1814405) 0.82
es/fixer/typescript 67127336 ns/iter (± 651894) 82249824 ns/iter (± 2064938) 0.82
es/hygiene/typescript 145974514 ns/iter (± 2218707) 183821532 ns/iter (± 978345) 0.79
es/resolver_with_hygiene/typescript 303994611 ns/iter (± 2797648) 380308672 ns/iter (± 1927970) 0.80
es/visitor/base-perf/module_clone 62531 ns/iter (± 209) 85458 ns/iter (± 144) 0.73
es/visitor/base-perf/fold_empty 66202 ns/iter (± 175) 94430 ns/iter (± 385) 0.70
es/visitor/base-perf/fold_noop_impl_all 66655 ns/iter (± 286) 95570 ns/iter (± 375) 0.70
es/visitor/base-perf/fold_noop_impl_vec 66902 ns/iter (± 179) 95407 ns/iter (± 455) 0.70
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 61 ns/iter (± 0) 0.92
es/visitor/base-perf/boxing_unboxed_clone 43 ns/iter (± 0) 44 ns/iter (± 0) 0.98
es/visitor/base-perf/boxing_boxed 111 ns/iter (± 0) 105 ns/iter (± 0) 1.06
es/visitor/base-perf/boxing_unboxed 81 ns/iter (± 0) 82 ns/iter (± 0) 0.99
es/visitor/base-perf/visit_empty 0 ns/iter (± 0)
es/visitor/base-perf/visit_contains_this 2614 ns/iter (± 9) 3527 ns/iter (± 67) 0.74
es/base/parallel/resolver/typescript 4633309368 ns/iter (± 293742905) 6572783784 ns/iter (± 329891972) 0.70
es/base/parallel/hygiene/typescript 1599777289 ns/iter (± 10437930) 2229949952 ns/iter (± 22444738) 0.72
misc/visitors/time-complexity/time 5 100 ns/iter (± 0) 100 ns/iter (± 0) 1
misc/visitors/time-complexity/time 10 293 ns/iter (± 0) 319 ns/iter (± 0) 0.92
misc/visitors/time-complexity/time 15 508 ns/iter (± 2) 651 ns/iter (± 2) 0.78
misc/visitors/time-complexity/time 20 889 ns/iter (± 6) 1243 ns/iter (± 10) 0.72
misc/visitors/time-complexity/time 40 3524 ns/iter (± 15) 6191 ns/iter (± 12) 0.57
misc/visitors/time-complexity/time 60 7279 ns/iter (± 14) 15569 ns/iter (± 32) 0.47
es/full-target/es2016 240667 ns/iter (± 754) 270226 ns/iter (± 1070) 0.89
es/full-target/es2017 226324 ns/iter (± 591) 260292 ns/iter (± 575) 0.87
es/full-target/es2018 215231 ns/iter (± 750) 249154 ns/iter (± 762) 0.86
es2020_nullish_coalescing 73925 ns/iter (± 445) 98914 ns/iter (± 355) 0.75
es2020_optional_chaining 85347 ns/iter (± 405) 114606 ns/iter (± 446) 0.74
es2022_class_properties 122023 ns/iter (± 348) 156687 ns/iter (± 335) 0.78
es2018_object_rest_spread 76334 ns/iter (± 195) 99913 ns/iter (± 327) 0.76
es2019_optional_catch_binding 66134 ns/iter (± 330) 89186 ns/iter (± 283) 0.74
es2017_async_to_generator 66316 ns/iter (± 232) 89205 ns/iter (± 181) 0.74
es2016_exponentiation 71337 ns/iter (± 550) 96133 ns/iter (± 173) 0.74
es2015_arrow 74447 ns/iter (± 300) 99139 ns/iter (± 319) 0.75
es2015_block_scoped_fn 71526 ns/iter (± 173) 97004 ns/iter (± 219) 0.74
es2015_block_scoping 133946 ns/iter (± 595) 186680 ns/iter (± 1317) 0.72

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.