perf(es): Avoid needless string comparisons (#9613)

swc-project · Oct 4, 2024 · ec0a62c · ec0a62c
1 parent e2e9a9c
commit ec0a62c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/.changeset/dull-carrots-smell.md b/.changeset/dull-carrots-smell.md
@@ -0,0 +1,7 @@
+---
+swc: patch
+swc_core: patch
+swc_ecma_transforms_base: patch
+---
+
+perf(es): Avoid needless string comparisons
diff --git a/crates/swc/src/builder.rs b/crates/swc/src/builder.rs
@@ -337,7 +337,6 @@ impl<'a, 'b, P: swc_ecma_visit::Fold> PassBuilder<'a, 'b, P> {
                 modules::import_analysis::import_analyzer(import_interop, ignore_dynamic),
                 need_analyzer
             ),
-            compat::reserved_words::reserved_words(),
             Optional::new(
                 helpers::inject_helpers(self.unresolved_mark),
                 self.inject_helpers

diff --git a/crates/swc_ecma_transforms_base/src/rename/analyzer/scope.rs b/crates/swc_ecma_transforms_base/src/rename/analyzer/scope.rs
@@ -8,7 +8,7 @@ use std::{
 #[cfg(feature = "concurrent-renamer")]
 use rayon::prelude::*;
 use rustc_hash::FxHashSet;
-use swc_atoms::Atom;
+use swc_atoms::{atom, Atom};
 use swc_common::{collections::AHashMap, util::take::Take, Mark, SyntaxContext};
 use swc_ecma_ast::*;
 use tracing::debug;
@@ -51,7 +51,7 @@ pub(super) struct ScopeData {
 
 impl Scope {
     pub(super) fn add_decl(&mut self, id: &Id, has_eval: bool, top_level_mark: Mark) {
-        if id.0 == "arguments" {
+        if id.0 == atom!("arguments") {
             return;
         }
 
@@ -73,7 +73,7 @@ impl Scope {
     }
 
     pub(super) fn add_usage(&mut self, id: Id) {
-        if id.0 == "arguments" {
+        if id.0 == atom!("arguments") {
             return;
         }