feat(es/common): Introduce pure Span and BytePos to handle `#__PU…

…RE__` (#9539) **Related issue:** - #9538
swc-project · Sep 9, 2024 · f63a481 · f63a481
1 parent 12488da
commit f63a481
Show file tree

Hide file tree

Showing 190 changed files with 962 additions and 2,180 deletions.
diff --git a/.changeset/serious-houses-help.md b/.changeset/serious-houses-help.md
@@ -0,0 +1,5 @@
+---
+swc_common: minor
+---
+
+feat(es/common): Introduce pure Span and BytePos to handle `#__PURE__`
diff --git a/crates/swc/src/builder.rs b/crates/swc/src/builder.rs
@@ -215,7 +215,6 @@ impl<'a, 'b, P: swc_ecma_visit::Fold> PassBuilder<'a, 'b, P> {
                 ),
                 Optional::new(
                     compat::es2022::es2022(
-                        comments,
                         compat::es2022::Config {
                             class_properties: compat::es2022::class_properties::Config {
                                 private_as_properties: assumptions.private_fields_as_properties,
@@ -271,7 +270,6 @@ impl<'a, 'b, P: swc_ecma_visit::Fold> PassBuilder<'a, 'b, P> {
                                 ignore_function_length: assumptions.ignore_function_length
                             },
                         },
-                        comments,
                         self.unresolved_mark
                     ),
                     should_enable(self.target, EsVersion::Es2017)

diff --git a/crates/swc/src/config/mod.rs b/crates/swc/src/config/mod.rs
@@ -1329,7 +1329,6 @@ impl ModuleConfig {
                         unresolved_mark,
                         config,
                         available_features,
-                        comments,
                     ))
                 } else {
                     let resolver = build_resolver(base_url, paths, config.resolve_fully);
@@ -1339,7 +1338,6 @@ impl ModuleConfig {
                         unresolved_mark,
                         config,
                         available_features,
-                        comments,
                     ))
                 }
             }
@@ -1350,7 +1348,6 @@ impl ModuleConfig {
                         unresolved_mark,
                         config,
                         available_features,
-                        comments,
                     ))
                 } else {
                     let resolver = build_resolver(base_url, paths, config.config.resolve_fully);
@@ -1362,7 +1359,6 @@ impl ModuleConfig {
                         unresolved_mark,
                         config,
                         available_features,
-                        comments,
                     ))
                 }
             }

diff --git a/crates/swc/tests/fixture/issues-1xxx/1455/case1/output/index.ts b/crates/swc/tests/fixture/issues-1xxx/1455/case1/output/index.ts
@@ -1,6 +1,6 @@
 var _async_to_generator = require("@swc/helpers/_/_async_to_generator");
 const SampleData = typedModel("SampleVideo", VideosSchema, undefined, undefined, {
-    byPlatform: function() {
+    byPlatform: /*#__PURE__*/ function() {
         var _ref = _async_to_generator._(function*(platform) {
             const result = yield this.find({
                 platform: {

diff --git a/crates/swc/tests/fixture/issues-1xxx/1455/case2/output/index.ts b/crates/swc/tests/fixture/issues-1xxx/1455/case2/output/index.ts
@@ -7,7 +7,7 @@ var obj = {
             platform: platform
         };
     },
-    byPlatform: function() {
+    byPlatform: /*#__PURE__*/ function() {
         var _ref = _async_to_generator._(function(platform) {
             var result;
             return _ts_generator._(this, function(_state) {

diff --git a/crates/swc/tests/fixture/issues-1xxx/1718/case1/output/index.ts b/crates/swc/tests/fixture/issues-1xxx/1718/case1/output/index.ts
@@ -10,7 +10,7 @@ function _scanUser() {
                 case 0:
                     return [
                         4,
-                        Promise.all(groups.map(function() {
+                        Promise.all(groups.map(/*#__PURE__*/ function() {
                             var _ref = _async_to_generator._(function(param) {
                                 var users, _iteratorNormalCompletion, _didIteratorError, _iteratorError, _iterator, _step, user, err;
                                 return _ts_generator._(this, function(_state) {

diff --git a/crates/swc/tests/fixture/issues-1xxx/1718/case2/output/index.ts b/crates/swc/tests/fixture/issues-1xxx/1718/case2/output/index.ts
@@ -4,7 +4,7 @@ function scanUser(groups) {
 }
 function _scanUser() {
     _scanUser = _async_to_generator._(function*(groups) {
-        yield Promise.all(groups.map(function() {
+        yield Promise.all(groups.map(/*#__PURE__*/ function() {
             var _ref = _async_to_generator._(function*({ users }) {
                 for (const user of users){
                     console.log("user", user);

diff --git a/crates/swc/tests/fixture/issues-1xxx/1799/case2-no-loose/output/index.js b/crates/swc/tests/fixture/issues-1xxx/1799/case2-no-loose/output/index.js
@@ -13,7 +13,7 @@ const _interop_require_default = require("@swc/helpers/_/_interop_require_defaul
 const _react = /*#__PURE__*/ _interop_require_default._(require("react"));
 function Foo() {
     return /*#__PURE__*/ _react.default.createElement("div", {
-        onClick: function() {
+        onClick: /*#__PURE__*/ function() {
             var _ref = _async_to_generator._(function*(e) {
                 yield doSomething();
             });

diff --git a/crates/swc/tests/fixture/issues-2xxx/2248/es5/output/index.js b/crates/swc/tests/fixture/issues-2xxx/2248/es5/output/index.js
@@ -1,6 +1,6 @@
 import { _ as _async_to_generator } from "@swc/helpers/_/_async_to_generator";
 import { _ as _ts_generator } from "@swc/helpers/_/_ts_generator";
-export var foo = function() {
+export var foo = /*#__PURE__*/ function() {
     var _ref = _async_to_generator(function() {
         return _ts_generator(this, function(_state) {
             try {

diff --git a/crates/swc/tests/fixture/issues-4xxx/4108/1/output/index.ts b/crates/swc/tests/fixture/issues-4xxx/4108/1/output/index.ts
@@ -6,7 +6,7 @@ import { _ as _ts_generator } from "@swc/helpers/_/_ts_generator";
 import { _ as _ts_values } from "@swc/helpers/_/_ts_values";
 import { Transaction } from "@solana/web3.js";
 import { WalletNotConnectedError } from "@solana/wallet-adapter-base";
-export var getErrorForTransaction = function() {
+export var getErrorForTransaction = /*#__PURE__*/ function() {
     var _ref = _async_to_generator(function(connection, txid) {
         var tx, errors;
         return _ts_generator(this, function(_state) {
@@ -157,7 +157,7 @@ function _sendTransactionsWithManualRetry() {
     });
     return _sendTransactionsWithManualRetry.apply(this, arguments);
 }
-export var sendTransactions = function() {
+export var sendTransactions = /*#__PURE__*/ function() {
     var _ref = _async_to_generator(function(connection, wallet, instructionSet, signersSet) {
         var _loop, _loop1, sequenceType, commitment, successCallback, failCallback, block, beforeTransactions, afterTransactions, _unsignedTxns, unsignedTxns, i, partiallySignedTransactions, fullySignedTransactions, signedTxns, pendingTxns, i1, _ret, result, _tmp;
         var _arguments = arguments;
@@ -364,7 +364,7 @@ export var sendTransactions = function() {
         return _ref.apply(this, arguments);
     };
 }();
-export var sendTransaction = function() {
+export var sendTransaction = /*#__PURE__*/ function() {
     var _ref = _async_to_generator(function(connection, wallet, instructions, signers) {
         var awaitConfirmation, commitment, includesFeePayer, block, transaction, _tmp, _transaction, _transaction1, _transaction2, rawTransaction, options, txid, slot, confirmation, errors;
         var _arguments = arguments;
@@ -482,7 +482,7 @@ export var sendTransaction = function() {
         return _ref.apply(this, arguments);
     };
 }();
-export var sendTransactionWithRetry = function() {
+export var sendTransactionWithRetry = /*#__PURE__*/ function() {
     var _ref = _async_to_generator(function(connection, wallet, instructions, signers) {
         var commitment, includesFeePayer, block, beforeSend, transaction, _tmp, _transaction, _transaction1, _transaction2, _ref, txid, slot;
         var _arguments = arguments;
@@ -777,7 +777,7 @@ function _awaitTransactionSignatureConfirmation() {
                     subId = 0;
                     return [
                         4,
-                        new Promise(function() {
+                        new Promise(/*#__PURE__*/ function() {
                             var _ref = _async_to_generator(function(resolve, reject) {
                                 return _ts_generator(this, function(_state) {
                                     switch(_state.label){

diff --git a/crates/swc/tests/fixture/issues-4xxx/4226/1/output/exec.js b/crates/swc/tests/fixture/issues-4xxx/4226/1/output/exec.js
@@ -1,7 +1,7 @@
 import { _ as _async_to_generator } from "@swc/helpers/_/_async_to_generator";
 import { _ as _ts_generator } from "@swc/helpers/_/_ts_generator";
 import "reflect-metadata";
-var v0 = function() {
+var v0 = /*#__PURE__*/ function() {
     var _ref = _async_to_generator(function(v1) {
         return _ts_generator(this, function(_state) {
             return [

diff --git a/crates/swc/tests/fixture/issues-4xxx/4226/2/output/exec.js b/crates/swc/tests/fixture/issues-4xxx/4226/2/output/exec.js
@@ -1,6 +1,6 @@
 import { _ as _async_to_generator } from "@swc/helpers/_/_async_to_generator";
 import "reflect-metadata";
-const v0 = function() {
+const v0 = /*#__PURE__*/ function() {
     var _ref = _async_to_generator(function*(v1) {
         return v1;
     });

diff --git a/crates/swc/tests/fixture/issues-4xxx/4226/3/output/exec.js b/crates/swc/tests/fixture/issues-4xxx/4226/3/output/exec.js
@@ -5,7 +5,7 @@ Object.defineProperty(exports, "__esModule", {
 var _async_to_generator = require("@swc/helpers/_/_async_to_generator");
 var _ts_generator = require("@swc/helpers/_/_ts_generator");
 require("reflect-metadata");
-var v0 = function() {
+var v0 = /*#__PURE__*/ function() {
     var _ref = _async_to_generator._(function(v1) {
         return _ts_generator._(this, function(_state) {
             return [

diff --git a/crates/swc/tests/fixture/issues-5xxx/5272/1/output/a.map b/crates/swc/tests/fixture/issues-5xxx/5272/1/output/a.map
@@ -1,5 +1,5 @@
 {
-  "mappings": ";;;+BACaA;;;eAAAA;;;;;;;oBADQ;AACd,IAAA,AAAMA,oBAAD,AAAL;;gBAAMA;aAAAA;kCAAAA;mCAAAA;;oBAAAA;;YACTC,KAAAA;mBAAAA,SAAAA;gBACI,OAAO,IAAI,IAAI,CAACC,GAAG;YACvB;;;WAHSF;EAAYG,UAAI",
+  "mappings": ";;;+BACaA;;;eAAAA;;;;;;;oBADQ;AACd,IAAA,AAAMA,oBAAN;;gBAAMA;aAAAA;kCAAAA;mCAAAA;;oBAAAA;;YACTC,KAAAA;mBAAAA,SAAAA;gBACI,OAAO,IAAI,IAAI,CAACC,GAAG;YACvB;;;WAHSF;EAAYG,UAAI",
   "names": [
     "Foo",
     "bar",

diff --git a/crates/swc/tests/fixture/issues-6xxx/6353/output/input.js b/crates/swc/tests/fixture/issues-6xxx/6353/output/input.js
@@ -1,37 +1,37 @@
 var _async_to_generator = require("@swc/helpers/_/_async_to_generator");
-(function() {
+/*#__PURE__*/ (function() {
     var _ref = _async_to_generator._(function*(x) {
         return 0;
     });
     return function(x) {
         return _ref.apply(this, arguments);
     };
 })().x++;
-(function() {
+/*#__PURE__*/ (function() {
     var _ref = _async_to_generator._(function*(x) {
         return 0;
     });
     return function(x) {
         return _ref.apply(this, arguments);
     };
 })().x--;
-++function() {
+++/*#__PURE__*/ function() {
     var _ref = _async_to_generator._(function*(x) {
         return 0;
     });
     return function(x) {
         return _ref.apply(this, arguments);
     };
 }().x;
---function() {
+--/*#__PURE__*/ function() {
     var _ref = _async_to_generator._(function*(x) {
         return 0;
     });
     return function(x) {
         return _ref.apply(this, arguments);
     };
 }().x;
-(function() {
+/*#__PURE__*/ (function() {
     var _ref = _async_to_generator._(function*(x) {
         return 0;
     });

diff --git a/crates/swc/tests/fixture/issues-6xxx/6730/output/index.ts b/crates/swc/tests/fixture/issues-6xxx/6730/output/index.ts
@@ -2,7 +2,7 @@ import { _ as r } from "@swc/helpers/_/_async_to_generator";
 export const styleLoader = ()=>{
     return {
         setup (t) {
-            t.onLoad(function() {
+            t.onLoad(/*#__PURE__*/ function() {
                 var t = r(function*(r) {});
                 return function(r) {
                     return t.apply(this, arguments);

diff --git a/crates/swc/tests/fixture/issues-8xxx/8155/1/output/1.js b/crates/swc/tests/fixture/issues-8xxx/8155/1/output/1.js
@@ -6,14 +6,14 @@ let someFn = (xx, x, y)=>[
         1,
         2,
         3
-    ], goodFunction = function() {
+    ], goodFunction = /*#__PURE__*/ function() {
     var _ref = _async_to_generator._(function*() {
         console.log(someFn(1, (yield getArray()), (yield getArray())));
     });
     return function() {
         return _ref.apply(this, arguments);
     };
-}(), badFunction = function() {
+}(), badFunction = /*#__PURE__*/ function() {
     var _ref = _async_to_generator._(function*() {
         console.log(someFn(1, (yield getArray()), (yield getArray())));
     });

diff --git a/crates/swc/tests/fixture/issues-8xxx/8155/2/output/1.js b/crates/swc/tests/fixture/issues-8xxx/8155/2/output/1.js
@@ -8,7 +8,7 @@ const getArray = ()=>[
         2,
         3
     ];
-const goodFunction = function() {
+const goodFunction = /*#__PURE__*/ function() {
     var _ref = _async_to_generator._(function*() {
         const rb = yield getArray();
         const rc = yield getArray();
@@ -18,7 +18,7 @@ const goodFunction = function() {
         return _ref.apply(this, arguments);
     };
 }();
-const badFunction = function() {
+const badFunction = /*#__PURE__*/ function() {
     var _ref = _async_to_generator._(function*() {
         console.log(someFn(1, (yield getArray()), (yield getArray())));
     });

diff --git a/crates/swc/tests/fixture/issues-8xxx/8375/1/output/index.ts b/crates/swc/tests/fixture/issues-8xxx/8375/1/output/index.ts
@@ -4,6 +4,6 @@ Object.defineProperty(exports, "__esModule", {
 });
 const _interop_require_wildcard = require("@swc/helpers/_/_interop_require_wildcard");
 const _hello = require("./src/hello");
-const _node = _interop_require_wildcard._(require("@sentry/node"));
+const _node = /*#__PURE__*/ _interop_require_wildcard._(require("@sentry/node"));
 _node;
-(0, _hello.helloWorld)("SWC"); /*#__PURE__*/ 
+(0, _hello.helloWorld)("SWC");
diff --git a/crates/swc/tests/fixture/issues-9xxx/9527/output/exec.js b/crates/swc/tests/fixture/issues-9xxx/9527/output/exec.js
@@ -8,7 +8,7 @@ var Base = function Base() {
 };
 ;
 expect(function() {
-    return new /*#__PURE__*/ (function(Base) {
+    return new (/*#__PURE__*/ function(Base) {
         "use strict";
         _inherits._(_class, Base);
         function _class() {
@@ -24,7 +24,7 @@ expect(function() {
     }(Base));
 }).toThrow();
 expect(function() {
-    return new /*#__PURE__*/ (function(Base) {
+    return new (/*#__PURE__*/ function(Base) {
         "use strict";
         _inherits._(_class, Base);
         function _class() {
@@ -39,7 +39,7 @@ expect(function() {
     }(Base));
 }).toThrow();
 expect(function() {
-    return new /*#__PURE__*/ (function(Base) {
+    return new (/*#__PURE__*/ function(Base) {
         "use strict";
         _inherits._(_class, Base);
         function _class() {
@@ -55,7 +55,7 @@ expect(function() {
     }(Base));
 }).toThrow();
 expect(function() {
-    return new /*#__PURE__*/ (function(Base) {
+    return new (/*#__PURE__*/ function(Base) {
         "use strict";
         _inherits._(_class, Base);
         function _class() {
@@ -68,7 +68,7 @@ expect(function() {
     }(Base));
 }).toThrow();
 expect(function() {
-    return new /*#__PURE__*/ (function(Base) {
+    return new (/*#__PURE__*/ function(Base) {
         "use strict";
         _inherits._(_class, Base);
         function _class() {
@@ -82,7 +82,7 @@ expect(function() {
     }(Base));
 }).toThrow();
 expect(function() {
-    return new /*#__PURE__*/ (function(Base) {
+    return new (/*#__PURE__*/ function(Base) {
         "use strict";
         _inherits._(_class, Base);
         function _class() {
@@ -95,7 +95,7 @@ expect(function() {
     }(Base));
 }).toThrow();
 expect(function() {
-    return new /*#__PURE__*/ (function(Base) {
+    return new (/*#__PURE__*/ function(Base) {
         "use strict";
         _inherits._(_class, Base);
         function _class() {
@@ -109,7 +109,7 @@ expect(function() {
     }(Base));
 }).toThrow();
 expect(function() {
-    return new /*#__PURE__*/ (function(Base) {
+    return new (/*#__PURE__*/ function(Base) {
         "use strict";
         _inherits._(_class, Base);
         function _class() {

diff --git a/crates/swc/tests/fixture/issues-9xxx/9527/output/test.js b/crates/swc/tests/fixture/issues-9xxx/9527/output/test.js
@@ -6,7 +6,7 @@ var Base = function Base() {
     _class_call_check._(this, Base);
 };
 ;
-new /*#__PURE__*/ (function(Base) {
+new (/*#__PURE__*/ function(Base) {
     "use strict";
     _inherits._(_class, Base);
     function _class() {
@@ -17,7 +17,7 @@ new /*#__PURE__*/ (function(Base) {
     }
     return _class;
 }(Base));
-new /*#__PURE__*/ (function(Base) {
+new (/*#__PURE__*/ function(Base) {
     "use strict";
     _inherits._(_class, Base);
     function _class() {
@@ -29,7 +29,7 @@ new /*#__PURE__*/ (function(Base) {
     }
     return _class;
 }(Base));
-new /*#__PURE__*/ (function(Base) {
+new (/*#__PURE__*/ function(Base) {
     "use strict";
     _inherits._(_class, Base);
     function _class() {
@@ -41,7 +41,7 @@ new /*#__PURE__*/ (function(Base) {
     }
     return _class;
 }(Base));
-new /*#__PURE__*/ (function(Base) {
+new (/*#__PURE__*/ function(Base) {
     "use strict";
     _inherits._(_class, Base);
     function _class() {