Skip to content

Commit

Permalink
fix(es/minifier): Correctly escape more characters (#8490)
Browse files Browse the repository at this point in the history
**Related issue:**

 - Closes #8484
  • Loading branch information
kdy1 authored Jan 9, 2024
1 parent a73ddc2 commit f7c4934
Show file tree
Hide file tree
Showing 4 changed files with 71 additions and 0 deletions.
65 changes: 65 additions & 0 deletions crates/swc/tests/fixture/issues-8xxx/8484/input/.swcrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
{
"jsc": {
"parser": {
"syntax": "ecmascript",
"jsx": true,
},
"target": "es2022",
"transform": {
"react": {
"development": true
}
},
"minify": {
"compress": {
"arguments": false,
"arrows": true,
"booleans": true,
"booleans_as_integers": false,
"collapse_vars": true,
"comparisons": true,
"computed_props": true,
"conditionals": true,
"dead_code": true,
"directives": true,
"drop_console": false,
"drop_debugger": true,
"evaluate": true,
"expression": false,
"hoist_funs": false,
"hoist_props": true,
"hoist_vars": false,
"if_return": true,
"join_vars": true,
"keep_classnames": false,
"keep_fargs": true,
"keep_fnames": false,
"keep_infinity": false,
"loops": true,
"negate_iife": true,
"properties": true,
"reduce_funcs": false,
"reduce_vars": false,
"side_effects": true,
"switches": true,
"typeofs": true,
"unsafe": false,
"unsafe_arrows": false,
"unsafe_comps": false,
"unsafe_Function": false,
"unsafe_math": false,
"unsafe_symbols": false,
"unsafe_methods": false,
"unsafe_proto": false,
"unsafe_regexp": false,
"unsafe_undefined": false,
"unused": true,
"const_to_let": true,
"pristine_globals": true
},
"mangle": false,
"inlineSourcesContent": false
}
},
"minify": false,
}
1 change: 1 addition & 0 deletions crates/swc/tests/fixture/issues-8xxx/8484/input/1.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
console.log(`\t`)
1 change: 1 addition & 0 deletions crates/swc/tests/fixture/issues-8xxx/8484/output/1.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
console.log(" ");
4 changes: 4 additions & 0 deletions crates/swc_ecma_minifier/src/compress/pure/strings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,12 @@ impl Pure<'_> {
let value = c
.replace("\\`", "`")
.replace("\\$", "$")
.replace("\\b", "\u{0008}")
.replace("\\f", "\u{000C}")
.replace("\\n", "\n")
.replace("\\r", "\r")
.replace("\\t", "\t")
.replace("\\v", "\u{000B}")
.replace("\\\\", "\\");

report_change!("converting a template literal to a string literal");
Expand Down

0 comments on commit f7c4934

Please sign in to comment.