fix(es/utils): Skip var declarator name in RefRewriter (#8125)

**Related issue:** - Closes #8124
swc-project · Oct 15, 2023 · fb81a36 · fb81a36 · github-actions · Oct 15, 2023
1 parent 3bca931
commit fb81a36
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/crates/swc_ecma_transforms_typescript/tests/fixture/issue-8124/input.ts b/crates/swc_ecma_transforms_typescript/tests/fixture/issue-8124/input.ts
@@ -0,0 +1,9 @@
+namespace Foo {
+    export var a = 1;
+    for (var a; a < 5; a++) {}
+}
+
+namespace Bar {
+    export var b = 2;
+    var b = 3;
+}
diff --git a/crates/swc_ecma_transforms_typescript/tests/fixture/issue-8124/output.js b/crates/swc_ecma_transforms_typescript/tests/fixture/issue-8124/output.js
@@ -0,0 +1,10 @@
+var Foo;
+(function(Foo) {
+    Foo.a = 1;
+    for(var a; Foo.a < 5; Foo.a++){}
+})(Foo || (Foo = {}));
+var Bar;
+(function(Bar) {
+    Bar.b = 2;
+    var b = 3;
+})(Bar || (Bar = {}));
diff --git a/crates/swc_ecma_utils/src/lib.rs b/crates/swc_ecma_utils/src/lib.rs
@@ -3062,6 +3062,11 @@ where
         }
     }
 
+    fn visit_mut_var_declarator(&mut self, n: &mut VarDeclarator) {
+        // skip var declarator name
+        n.init.visit_mut_with(self);
+    }
+
     fn visit_mut_pat(&mut self, n: &mut Pat) {
         match n {
             Pat::Ident(BindingIdent { id, .. }) => {
Benchmark suite	Current: `fb81a36`	Previous: `57b171d`	Ratio
`es/full/bugs-1`	`287822` ns/iter (`± 6426`)	`285962` ns/iter (`± 3358`)	`1.01`
`es/full/minify/libraries/antd`	`1401968362` ns/iter (`± 11888127`)	`1405561721` ns/iter (`± 9634710`)	`1.00`
`es/full/minify/libraries/d3`	`296948759` ns/iter (`± 2444667`)	`293578866` ns/iter (`± 4252848`)	`1.01`
`es/full/minify/libraries/echarts`	`1129992687` ns/iter (`± 6388478`)	`1133709593` ns/iter (`± 12589371`)	`1.00`
`es/full/minify/libraries/jquery`	`88726595` ns/iter (`± 260285`)	`88688386` ns/iter (`± 331459`)	`1.00`
`es/full/minify/libraries/lodash`	`103737288` ns/iter (`± 339625`)	`103735700` ns/iter (`± 689895`)	`1.00`
`es/full/minify/libraries/moment`	`52141486` ns/iter (`± 168090`)	`52250690` ns/iter (`± 88177`)	`1.00`
`es/full/minify/libraries/react`	`18764891` ns/iter (`± 40483`)	`18778922` ns/iter (`± 50073`)	`1.00`
`es/full/minify/libraries/terser`	`232302121` ns/iter (`± 2877678`)	`231506227` ns/iter (`± 1078772`)	`1.00`
`es/full/minify/libraries/three`	`412834407` ns/iter (`± 2715800`)	`410787978` ns/iter (`± 5128915`)	`1.00`
`es/full/minify/libraries/typescript`	`2809513681` ns/iter (`± 13033301`)	`2807234021` ns/iter (`± 7277322`)	`1.00`
`es/full/minify/libraries/victory`	`603199352` ns/iter (`± 4997236`)	`605929363` ns/iter (`± 9900039`)	`1.00`
`es/full/minify/libraries/vue`	`126433142` ns/iter (`± 564432`)	`126414774` ns/iter (`± 808011`)	`1.00`
`es/full/codegen/es3`	`33545` ns/iter (`± 90`)	`34193` ns/iter (`± 157`)	`0.98`
`es/full/codegen/es5`	`33708` ns/iter (`± 53`)	`34278` ns/iter (`± 113`)	`0.98`
`es/full/codegen/es2015`	`33744` ns/iter (`± 167`)	`34207` ns/iter (`± 107`)	`0.99`
`es/full/codegen/es2016`	`33628` ns/iter (`± 89`)	`34293` ns/iter (`± 89`)	`0.98`
`es/full/codegen/es2017`	`33789` ns/iter (`± 72`)	`34310` ns/iter (`± 52`)	`0.98`
`es/full/codegen/es2018`	`33809` ns/iter (`± 146`)	`34277` ns/iter (`± 119`)	`0.99`
`es/full/codegen/es2019`	`33763` ns/iter (`± 65`)	`34270` ns/iter (`± 83`)	`0.99`
`es/full/codegen/es2020`	`33683` ns/iter (`± 86`)	`34131` ns/iter (`± 60`)	`0.99`
`es/full/all/es3`	`175859848` ns/iter (`± 569821`)	`176321917` ns/iter (`± 1239792`)	`1.00`
`es/full/all/es5`	`169627433` ns/iter (`± 1065745`)	`169121224` ns/iter (`± 756804`)	`1.00`
`es/full/all/es2015`	`128372943` ns/iter (`± 917145`)	`126824512` ns/iter (`± 646171`)	`1.01`
`es/full/all/es2016`	`128281273` ns/iter (`± 772794`)	`126821647` ns/iter (`± 773319`)	`1.01`
`es/full/all/es2017`	`127147539` ns/iter (`± 776226`)	`126388716` ns/iter (`± 544512`)	`1.01`
`es/full/all/es2018`	`125152360` ns/iter (`± 1349576`)	`124121322` ns/iter (`± 880802`)	`1.01`
`es/full/all/es2019`	`123736848` ns/iter (`± 601171`)	`123247631` ns/iter (`± 850284`)	`1.00`
`es/full/all/es2020`	`120386269` ns/iter (`± 1326072`)	`118898476` ns/iter (`± 767759`)	`1.01`
`es/full/parser`	`562959` ns/iter (`± 4290`)	`561380` ns/iter (`± 5707`)	`1.00`
`es/full/base/fixer`	`17712` ns/iter (`± 61`)	`19058` ns/iter (`± 112`)	`0.93`
`es/full/base/resolver_and_hygiene`	`83610` ns/iter (`± 92`)	`83243` ns/iter (`± 113`)	`1.00`