Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@swc/wasm-web references wasm_bg.js but it does not get published together with it #1291

Closed
9oelM opened this issue Dec 26, 2020 · 5 comments · Fixed by #1293
Closed

@swc/wasm-web references wasm_bg.js but it does not get published together with it #1291

9oelM opened this issue Dec 26, 2020 · 5 comments · Fixed by #1293
Labels

Comments

@9oelM
Copy link
Contributor

9oelM commented Dec 26, 2020

It's not about @swc/core, but it's more of just publishing problem, I guess.

Screen Shot 2020-12-26 at 6 18 43 PM

For some reason it exports wasm_bg.js, but it does not come with wasm_bg.js anyways (see left side).

Where is wasm_bg.js supposed to come from?

How to reproduce

Just install @swc/wasm-web with yarn add @swc-wasm-web and see the actual package content inside node_modules.

@9oelM 9oelM added the C-bug label Dec 26, 2020
@9oelM 9oelM mentioned this issue Dec 26, 2020
@9oelM
Copy link
Contributor Author

9oelM commented Dec 26, 2020

Ok well we are using wasm-pack to roll it out to wasm, and there's a relevant issue on this. may need a fix on github workflow. rustwasm/wasm-pack#837

@kdy1
Copy link
Member

kdy1 commented Dec 26, 2020

It seems like we need to modify (generated) package.json file

@9oelM
Copy link
Contributor Author

9oelM commented Dec 26, 2020

I will try to figure out a way

@9oelM
Copy link
Contributor Author

9oelM commented Dec 26, 2020

Yeah. So just like what you said, inside package.json:

  "files": [
    "wasm_bg.wasm",
    "wasm.js",
    "wasm_bg.js",
    "wasm.d.ts"
  ],

This will just do it. I will make a PR.

@swc-bot
Copy link
Collaborator

swc-bot commented Oct 26, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

3 participants