Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Prepend/append correctly #3367

Merged
merged 14 commits into from
Jan 26, 2022
Merged

fix(es/minifier): Prepend/append correctly #3367

merged 14 commits into from
Jan 26, 2022
+100 −22

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 26, 2022 •
edited
Loading

swc_ecma_minifier:

  • Add some assertions for injections.
  • Fix prepend/append logic of statements.

@kdy1 kdy1 added this to the v1.2.135 milestone Jan 26, 2022
@kdy1 kdy1 changed the title fix(es/minifier): Ensure all side-effects are preserved fix(es/minifier): Prepend/append correctly Jan 26, 2022
@kdy1 kdy1 marked this pull request as ready for review January 26, 2022 03:50
@kdy1 kdy1 merged commit 703972d into swc-project:main Jan 26, 2022
@kdy1 kdy1 deleted the minifier-bug branch January 26, 2022 04:11
@kdy1 kdy1 mentioned this pull request Jan 26, 2022
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jan 26, 2022
@kdy1
feat(next-swc): Update swc (#33675)
f0e31ee 
This PR applies

 - swc-project/swc#3367
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@kdy1 @natew
feat(next-swc): Update swc (vercel#33675)
8ebda6d 
This PR applies

 - swc-project/swc#3367
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v1.2.135
Development

Successfully merging this pull request may close these issues.
1 participant
@kdy1