feat(swc/cli): implements few compile flags #4125
Merged
+63
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note, I haven't thought deeply but implementing |
kdy1
reviewed
Mar 23, 2022
| let config_file = if let Some(config_file_path) = &self.config_file { | ||
| let config_file_contents = fs::read(config_file_path)?; | ||
| serde_json::from_slice(&config_file_contents) | ||
| .map_err(|e| anyhow::anyhow!("{}", e)) |
There was a problem hiding this comment.
Is this required?
I think .context("message") is enough to convert an error to anyhow::Error
There was a problem hiding this comment.
yes, looks like old oversight.
kwonoj
force-pushed
the
feat-impl-compile-commands
branch
from
25f1e0a to
00b740f
Compare
kdy1
approved these changes
Mar 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update few more flags for the compile command.
Related issue (if exists):
#4017