Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VisitMut bound to React preset return type #5499

Merged
merged 5 commits into from
Aug 17, 2022
Merged

Add VisitMut bound to React preset return type #5499

merged 5 commits into from
Aug 17, 2022
+2 −2

Conversation

alexkirsz
Copy link
Contributor

Description:

This is necessary in order to use this preset with visit_mut_with.

BREAKING CHANGE:

None.
.

Related issue (if exists):

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

kdy1
kdy1 approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_transforms_react

@kdy1 kdy1 self-assigned this Aug 15, 2022
@kdy1 kdy1 enabled auto-merge (squash) August 16, 2022 12:35
@kdy1 kdy1 added this to the Planned milestone Aug 16, 2022
swc-bot
swc-bot reviewed Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge August 16, 2022 13:13
@kdy1 kdy1 enabled auto-merge (squash) August 17, 2022 06:12
swc-bot
swc-bot reviewed Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge August 17, 2022 08:34
@kdy1 kdy1 merged commit 14606d9 into swc-project:main Aug 17, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.2.238, v1.2.239 Aug 17, 2022
@alexkirsz alexkirsz deleted the alexkirsz/react-visitmut branch August 22, 2022 16:14
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.2.239
Development

Successfully merging this pull request may close these issues.
4 participants
@alexkirsz @CLAassistant @kdy1 @swc-bot