[Merged by Bors] - Fix parsing of declare #624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2020
Previously all children in declare context were marked as `declare`. It's wrong, and I fixed to set declare: true only on the exact node
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2020
Previously all children in declare context were marked as `declare`. It's wrong, and I fixed to set declare: true only on the exact node
Build succeeded
|
Pull request successfully merged into master. |
bors
bot
changed the title
|
Does have a release？
|
|
@kdy1 |
|
@runnerSnail It's already released. |
|
|
|
It seems like a bug of typescript::strip pass (and quite simple to fix) |
|
@kdy1 |
|
@runnerSnail I'll fix it now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all children in declare context were marked as
declare. It's wrong, and I fixed to set declare: true only on the exact node