-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Remove empty expression in expression statement with top level await #630
Conversation
bors r+ |
…630) Eats the semi-colon. This doesn't compile though because the target of that folder is ES2015. Also, this is kind of strange for me to put the tests in the "typescript" folder. Should we create something more general? You can take over this PR if you'd like!
Build failed
|
@kdy1 do you have any suggestions for resolving this failed test:
I feel like these AST parsing tests should not be dependent on the specified target and any target specific tests should live elsewhere. If I remove this requirement though then another test fails that checks for this error. |
Hmm... 🤔 |
@kdy1 for sure. Please! |
bors r+ |
…630) Eats the semi-colon. This doesn't compile (edit: doesn't compile the code in the tests) though because the target of that folder is ES2015. Also, this is kind of strange for me to put the tests in the "typescript" folder. Should we create something more general? You can take over this PR if you'd like!
Build succeeded
|
Pull request successfully merged into master. |
Eats the semi-colon.
This doesn't compile (edit: doesn't compile the code in the tests) though because the target of that folder is ES2015. Also, this is kind of strange for me to put the tests in the "typescript" folder. Should we create something more general?
You can take over this PR if you'd like!