Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Don't drop used variables from sequential inliner #6520

Merged
merged 10 commits into from
Nov 29, 2022
Merged

fix(es/minifier): Don't drop used variables from sequential inliner #6520

merged 10 commits into from
Nov 29, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 28, 2022

Description:

Related issue:

Original output:

"use strict";
(self.webpackChunk_N_E = self.webpackChunk_N_E || []).push([
    [
        715
    ],
    {
        3266: function(__unused_webpack_module, __webpack_exports__, __webpack_require__) {
            __webpack_require__.d(__webpack_exports__, {
                h: function() {
                    return LocalDate;
                }
            }), isInit = !0;
        }
    }
]);

@kdy1 kdy1 added this to the Planned milestone Nov 28, 2022
@kdy1 kdy1 self-assigned this Nov 28, 2022
@kdy1 kdy1 marked this pull request as ready for review November 28, 2022 03:07
@kdy1 kdy1 requested a review from jridgewell November 28, 2022 03:07
kdy1
kdy1 commented Nov 28, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 enabled auto-merge (squash) November 29, 2022 02:16
swc-bot
swc-bot reviewed Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit b394f9f into swc-project:main Nov 29, 2022
@kdy1 kdy1 deleted the min-joda branch November 29, 2022 04:12
@kdy1 kdy1 mentioned this pull request Nov 29, 2022
Closed
@kdy1 kdy1 modified the milestones: Planned, v1.3.21 Nov 30, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

@jridgewell jridgewell jridgewell approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.21
Development

Successfully merging this pull request may close these issues.

swc minifier breaks @js-joda/core
3 participants
@kdy1 @jridgewell @swc-bot