fix(swc_ecma_codegen): fix LineCol calculation of printed files #6763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several issues with the way we updated the current `LineCol` position during the printing of the generated file: - We used `chars` and `char_indices` (UTF-32) instead of `encode_utf16` (UTF-16) chars. - JS uses UCS-2 (basically UTF-16) for its strings, and sourcemaps default to that implicitly. - `\r` was incorrectly handled - it didn't add a `line_start`, only `\n` did - `\r\n` was incorrectly handled - It was trying to let `\n` path handle the `line_start`, but it called `chars.next()` which ate the `\n` char. I also took the opportunity to avoid the `Vec` allocations and reduced some code duplication.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There were several issues with the way we updated the current
LineColposition during the printing of the generated file:charsandchar_indices(UTF-32) instead ofencode_utf16(UTF-16) chars.\rwas incorrectly handledline_start, only\ndid\r\nwas incorrectly handled\npath handle theline_start, but it calledchars.next()which ate the\nchar.I also took the opportunity to avoid the
Vecallocations and reduced some code duplication.See the before and after
BREAKING CHANGE:
Related issue (if exists):
Fixes #6694