Make usage of lexical from swc_ecma_parser optional #7757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing num-bigint in its place if the feature is omitted.
KthulupwnsAsura
approved these changes
Aug 4, 2023
|
Note that either this PR or #7758 should be accepted, but not both. |
|
Thank you! I'll close this in favor of #7758 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes lexical part of the default features for the swc_ecma_parser crate but allows it to be turned off to use BigInt for equivalent parsing of large numbers.
Description: As discussed in #7752, lexical contains a number of soundness issues but doesn't appear to be actively supported. Given the relatively low integration surface it seems reasonable to replace the usage of lexical with another package to avoid this issue. This does so in an optional fashion so that the decision can be made by the user which mechanism to use.
Related issue (if exists): #7752