Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): Evaluate more toFixed expressions #8109

Merged
merged 4 commits into from
Oct 13, 2023
Merged

feat(es/minifier): Evaluate more toFixed expressions #8109

merged 4 commits into from
Oct 13, 2023

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari marked this pull request as ready for review October 12, 2023 18:18
@kdy1 kdy1 self-assigned this Oct 13, 2023
@kdy1 kdy1 added this to the Planned milestone Oct 13, 2023
kdy1
kdy1 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 changed the title fix(es/minifier): Evaluate more toFixed experssions feat(es/minifier): Evaluate more toFixed experssions Oct 13, 2023
@kdy1 kdy1 changed the title feat(es/minifier): Evaluate more toFixed experssions feat(es/minifier): Evaluate more toFixed expressions Oct 13, 2023
@kdy1 kdy1 enabled auto-merge (squash) October 13, 2023 02:36
swc-bot
swc-bot reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge October 13, 2023 02:50
@kdy1 kdy1 enabled auto-merge (squash) October 13, 2023 02:51
swc-bot
swc-bot reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge October 13, 2023 02:55
@kdy1 kdy1 enabled auto-merge (squash) October 13, 2023 03:06
@kdy1 kdy1 disabled auto-merge October 13, 2023 03:23
kdy1
kdy1 requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

@magic-akari
Copy link
Member Author

This test seems to be fragile. All tests pass on my machine.

@kdy1
Copy link
Member

kdy1 commented Oct 13, 2023

I'll investigate

@kdy1 kdy1 enabled auto-merge (squash) October 13, 2023 05:44
@kdy1 kdy1 disabled auto-merge October 13, 2023 06:06
@kdy1 kdy1 merged commit 7da3f52 into swc-project:main Oct 13, 2023
283 checks passed
@magic-akari magic-akari deleted the es/minifier/evaluate branch October 15, 2023 14:14
@kdy1 kdy1 modified the milestones: Planned, v1.3.94 Oct 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 requested changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.94
Development

Successfully merging this pull request may close these issues.
3 participants
@magic-akari @kdy1 @swc-bot