Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/ast): Support import phase #8279

Merged
merged 2 commits into from
Jan 19, 2024
Merged

feat(es/ast): Support import phase #8279

merged 2 commits into from
Jan 19, 2024
+2,436 −718

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Nov 13, 2023 •
edited by kdy1
Loading

@magic-akari magic-akari force-pushed the es/syntax/import-phase branch from 998d44d to 6274871 Compare November 13, 2023 17:31
@kdy1 kdy1 self-assigned this Nov 13, 2023
@kdy1 kdy1 added this to the Planned milestone Nov 13, 2023
@magic-akari magic-akari marked this pull request as ready for review November 14, 2023 03:05
@magic-akari magic-akari requested review from a team as code owners November 14, 2023 03:05
@magic-akari
Copy link
Member Author

How to fix node bindings?

magic-akari
magic-akari commented Nov 14, 2023
View reviewed changes
crates/swc_ecma_parser/src/parser/stmt/module_item.rs Outdated
Comment on lines 110 to 111
let is_phase = is_one_of!(self, BindingIdent, '{', '*')
&& (!is!(self, "from") || peeked_is!(self, "from"));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to peek more than one token?
https://github.com/oxc-project/oxc/blob/891d353adeefbd54e56c2ff3e89a49697da0bc5b/crates/oxc_parser/src/js/module.rs#L457

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a method to do so. Also, we need to roll-up AST-breaking changes, so I'll work on #8026 and the setter prop AST thing.

@kdy1
Copy link
Member

kdy1 commented Nov 14, 2023

For node bindings, you can do

swc/.github/workflows/CI.yml

Lines 170 to 175 in 0c05f6e

- name: Patch
shell: bash
run: |
echo '[patch.crates-io]' >> bindings/Cargo.toml
./scripts/cargo/patch-section.sh >> bindings/Cargo.toml
cd bindings && cargo update -p swc_core

@magic-akari
Copy link
Member Author

Plugin test failed in node bindings test.
It's a breaking change since the AST changed.

IMO it's expected result, right?

@kdy1
Copy link
Member

kdy1 commented Nov 14, 2023

Yes, it's expected

@magic-akari magic-akari force-pushed the es/syntax/import-phase branch from 0ce55c3 to 69332c7 Compare November 20, 2023 07:50
kdy1
kdy1 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll merge this when other AST-breaking changes are ready.

swc-bump:

  • swc_common
  • swc_ecma_ast --breaking

@petamoriken petamoriken mentioned this pull request Jan 8, 2024
Merged
@kdy1 kdy1 changed the base branch from main to dev January 19, 2024 05:28
kdy1
kdy1 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase it with the dev branch?

swc-bump:

  • dbg-swc

@magic-akari magic-akari force-pushed the es/syntax/import-phase branch from 329cbed to d896998 Compare January 19, 2024 06:21
@magic-akari
Copy link
Member Author

Can you rebase it with the dev branch?

done.

@kdy1 kdy1 merged commit 200a83d into swc-project:dev Jan 19, 2024
136 of 140 checks passed
@kdy1 kdy1 mentioned this pull request Jan 19, 2024
Merged
@kdy1 kdy1 modified the milestones: Planned, v1.3.105 Jan 21, 2024
kdy1 pushed a commit that referenced this pull request Jan 21, 2024
@magic-akari @kdy1
feat(es/ast): Support import phase (#8279)
72048ae 
**Description:**

- https://github.com/tc39/proposal-source-phase-imports
@kdy1 kdy1 mentioned this pull request Jan 24, 2024
Merged
@magic-akari magic-akari deleted the es/syntax/import-phase branch February 4, 2024 02:41
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.105
Development

Successfully merging this pull request may close these issues.
2 participants
@magic-akari @kdy1