Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/codegen): Fix codegen of ts specific syntax in class props #8426

Merged
merged 4 commits into from
Dec 17, 2023
Merged

fix(es/codegen): Fix codegen of ts specific syntax in class props #8426

merged 4 commits into from
Dec 17, 2023

Conversation

dsherret
Copy link
Contributor

Description: This fixes the codegen of private properties with is_optional ordefinite and class properties with definite.

Related issue (if exists): None

@dsherret dsherret requested a review from a team as a code owner December 15, 2023 14:40
kdy1
kdy1 approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_codegen

@kdy1 kdy1 enabled auto-merge (squash) December 16, 2023 06:44
@kdy1 kdy1 added this to the Planned milestone Dec 16, 2023
@kdy1 kdy1 merged commit 7566ddf into swc-project:main Dec 17, 2023
141 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.101 Dec 18, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@Austaras Austaras Austaras approved these changes

@magic-akari magic-akari magic-akari approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.101
Development

Successfully merging this pull request may close these issues.
4 participants
@dsherret @magic-akari @Austaras @kdy1