Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/codegen): Fix codegen of \\0 #8433

Merged
merged 14 commits into from
Jan 19, 2024
Merged

fix(es/codegen): Fix codegen of \\0 #8433

merged 14 commits into from
Jan 19, 2024
+81 −49

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 18, 2023

@kdy1 kdy1 added this to the Planned milestone Dec 18, 2023
@kdy1 kdy1 self-assigned this Dec 18, 2023
@kdy1 kdy1 marked this pull request as ready for review December 18, 2023 09:02
@kdy1 kdy1 requested a review from a team as a code owner December 18, 2023 09:02
kdy1
kdy1 commented Dec 18, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_codegen

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 3, 2024
View reviewed changes
@kdy1 kdy1 marked this pull request as draft January 3, 2024 19:54
kdy1
kdy1 commented Jan 18, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_codegen

@kdy1 kdy1 marked this pull request as ready for review January 18, 2024 12:06
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 18, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) January 18, 2024 12:08
swc-bot
swc-bot reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 9f1ce3a into swc-project:main Jan 19, 2024
142 checks passed
@kdy1 kdy1 deleted the issue-8431 branch January 19, 2024 02:11
@kdy1 kdy1 modified the milestones: Planned, v1.3.105 Jan 21, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.105
Development

Successfully merging this pull request may close these issues.

Incorrect minimization of \0 and \x00 in v1.3.28+
2 participants
@kdy1 @swc-bot