Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/codegen): Fix codegen of a property key in ascii-only mode #8493

Merged
merged 7 commits into from
Jan 14, 2024
Merged

fix(es/codegen): Fix codegen of a property key in ascii-only mode #8493

merged 7 commits into from
Jan 14, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 9, 2024

@kdy1 kdy1 added this to the Planned milestone Jan 9, 2024
@kdy1 kdy1 self-assigned this Jan 9, 2024
@kdy1 kdy1 marked this pull request as ready for review January 9, 2024 19:23
@kdy1 kdy1 requested a review from a team as a code owner January 9, 2024 19:23
kdy1
kdy1 commented Jan 9, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 9, 2024
View reviewed changes
@chenjiahan chenjiahan mentioned this pull request Jan 10, 2024
Closed
magic-akari
magic-akari previously approved these changes Jan 10, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) January 14, 2024 05:58
@kdy1 kdy1 dismissed stale reviews from kodiakhq[bot] and magic-akari via bab4e96 January 14, 2024 07:30
@kdy1 kdy1 merged commit 8d9bf4c into swc-project:main Jan 14, 2024
143 checks passed
@kdy1 kdy1 deleted the issue-8491 branch January 14, 2024 08:11
@kdy1 kdy1 modified the milestones: Planned, v1.3.103 Jan 15, 2024
@kdy1 kdy1 mentioned this pull request Jan 19, 2024
Merged
kdy1 added a commit that referenced this pull request Jan 19, 2024
@kdy1
test(es/codegen): Add a JS test for ascii-only mode (#8519)
974c6a0 
**Description:**

The issue was fixed by #8493, but it was not included in the latest release because of the wrong bump comment.

**Related issue:**

 - Closes #8491
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

@magic-akari magic-akari magic-akari left review comments

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.103
Development

Successfully merging this pull request may close these issues.

1.3.98 swc minify breaks property name with non-ascii char when asciiOnly is on
2 participants
@kdy1 @magic-akari