Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/module): Fix resolving of dependencies #8533

Merged
merged 27 commits into from
Jan 21, 2024
Merged

fix(es/module): Fix resolving of dependencies #8533

merged 27 commits into from
Jan 21, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 21, 2024 •
edited
Loading

Description:

I changed the signature of Resolve because there was a need to pass the value part from jsc.paths to the caller.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jan 21, 2024
@kdy1 kdy1 self-assigned this Jan 21, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8fe22fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title fix(es/module): Fix resolving of dependencies with various file extensions fix(es/module): Fix resolving of dependencies Jan 21, 2024
kdy1
kdy1 commented Jan 21, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_loader --breaking

@kdy1 kdy1 marked this pull request as ready for review January 21, 2024 06:17
@kdy1 kdy1 requested review from a team as code owners January 21, 2024 06:17
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 21, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) January 21, 2024 06:17
@kdy1 kdy1 disabled auto-merge January 21, 2024 06:46
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 21, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) January 21, 2024 10:55
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 21, 2024
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 21, 2024
View reviewed changes
@kdy1 kdy1 disabled auto-merge January 21, 2024 12:35
@kdy1 kdy1 merged commit 71fb5c1 into swc-project:main Jan 21, 2024
141 checks passed
@kdy1 kdy1 deleted the issue-8184 branch January 21, 2024 12:35
@kdy1 kdy1 modified the milestones: Planned, v1.3.106 Jan 24, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.106
Development

Successfully merging this pull request may close these issues.

In projects that mix js, ts, jsx, tsx, the build results of version 1.3.79 have file extensions .js, .jsx.
1 participant
@kdy1