Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): Parse await using in for head #8775

Merged
merged 8 commits into from
Mar 26, 2024
Merged

fix(es/parser): Parse await using in for head #8775

merged 8 commits into from
Mar 26, 2024

Conversation

magic-akari
Copy link
Member

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b51de8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@magic-akari magic-akari marked this pull request as ready for review March 25, 2024 13:05
@magic-akari magic-akari requested a review from a team as a code owner March 25, 2024 13:05
@magic-akari
Copy link
Member Author 

failures:
    identity____swc_ecma_parser__tests__tsc__awaitUsingDeclarationsInForAwaitOf_ts
    identity____swc_ecma_parser__tests__tsc__awaitUsingDeclarationsInForOf_1_ts

Cannot figure out why these tests are failing.
Should I ignore them?

@kdy1 kdy1 added this to the Planned milestone Mar 26, 2024
@kdy1
Copy link
Member

kdy1 commented Mar 26, 2024

Yeah, I think so. I looked at the test lo, but it does not look like a regression

kdy1
kdy1 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser
  • swc_core

@kdy1 kdy1 enabled auto-merge (squash) March 26, 2024 03:18
swc-bot
swc-bot reviewed Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 53fd09c into swc-project:main Mar 26, 2024
142 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.4.11 Mar 27, 2024
@magic-akari magic-akari deleted the fix/issue-8774 branch April 12, 2024 02:42
@swc-project swc-project locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.4.11
Development

Successfully merging this pull request may close these issues.

await using Declarations in for-of Loops is not supported.
3 participants
@magic-akari @kdy1 @swc-bot