Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Allow self-reference #8884

Closed
wants to merge 7 commits into from
Closed

fix(es/minifier): Allow self-reference #8884

wants to merge 7 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 23, 2024

@kdy1 kdy1 added this to the Planned milestone Apr 23, 2024
@kdy1 kdy1 self-assigned this Apr 23, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 47d320a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review April 23, 2024 03:29
@kdy1 kdy1 requested a review from a team as a code owner April 23, 2024 03:29
@kdy1 kdy1 enabled auto-merge (squash) April 23, 2024 03:29
kdy1
kdy1 commented Apr 23, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_core
  • swc_ecma_minifier

swc-bot
swc-bot reviewed Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge April 23, 2024 11:08
@kdy1
Copy link
Member Author

kdy1 commented Apr 23, 2024

closing in favor of #8887

@kdy1 kdy1 closed this Apr 23, 2024
@kdy1 kdy1 deleted the issue-8841 branch April 23, 2024 12:33
@kdy1 kdy1 modified the milestones: Planned, v1.5.1, v1.5.0 Apr 27, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

minifier: self-referential var declaration makes inlining invalid
2 participants
@kdy1 @swc-bot