Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(es/ast): Remove unused fields of TsPropertySignature #8955

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

lucacasonato
Copy link
Contributor

@lucacasonato lucacasonato commented May 14, 2024

Description:

TsPropertySignature can not have params, type params, or an initializer.

BREAKING CHANGE:

Yes. Any users looking into these fields should stop - they are always empty.

@lucacasonato lucacasonato requested review from a team as code owners May 14, 2024 13:46
Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: ac2fe73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lucacasonato
Copy link
Contributor Author

I suggest you review the two commits independently. The second one is just test expectation updates caused by the first commit. All code changes are in the first commit.

kdy1
kdy1 previously approved these changes May 20, 2024
@kdy1 kdy1 added this to the Planned milestone May 20, 2024
@kdy1 kdy1 self-assigned this Jun 14, 2024
- TsPropertySignature can not have params, type params, or an initializer.
- TsGetterSignature can not be optional or readonly.
- TsSetterSignature can not be optional or readonly.
- TsMethodSignature can not be readonly.
@kdy1 kdy1 changed the title chore: remove unused, always empty fields from TsPropertySignature refactor(es/ast): Remove unused fields from TsPropertySignature Jun 14, 2024
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_ast --breaking

@kdy1 kdy1 enabled auto-merge (squash) June 14, 2024 06:12
@kdy1 kdy1 changed the title refactor(es/ast): Remove unused fields from TsPropertySignature refactor(es/ast): Remove unused fields of TsPropertySignature Jun 14, 2024
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge June 14, 2024 12:56
@kdy1 kdy1 merged commit 6306778 into swc-project:main Jun 14, 2024
105 of 106 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.6.0 Jun 16, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants