Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/typescript): Fix tricky cases in TS fast strip #9159

Merged
merged 12 commits into from
Jul 6, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 6, 2024

Description:

We can leverage lexer information to handle tricky cases.

@kdy1 kdy1 self-assigned this Jul 6, 2024
@kdy1 kdy1 requested a review from magic-akari July 6, 2024 03:47
@kdy1
Copy link
Member Author

kdy1 commented Jul 6, 2024

@magic-akari Do you have any other tricky cases in your mind?

@magic-akari
Copy link
Member

I believe it is sufficient to handle edge cases.

@kdy1 kdy1 marked this pull request as ready for review July 6, 2024 04:01
@kdy1 kdy1 requested review from a team as code owners July 6, 2024 04:01
@kdy1 kdy1 enabled auto-merge (squash) July 6, 2024 04:01
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_core
  • swc_ecma_parser
  • swc_fast_ts_strip

@kdy1 kdy1 added this to the Planned milestone Jul 6, 2024
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge July 6, 2024 04:53
@kdy1 kdy1 enabled auto-merge (squash) July 6, 2024 04:54
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 2bc51b8 into swc-project:main Jul 6, 2024
150 checks passed
@kdy1 kdy1 deleted the ts-lexer branch July 6, 2024 05:24
@kdy1 kdy1 modified the milestones: Planned, v1.6.10 Jul 6, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants