fix(es/minifier): Collect raw str values for new Tpl element #9261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kdy1 Oops, a compress case failed, i am trying to fix |
stormslowly
changed the title
CodSpeed Performance ReportMerging #9261 will not alter performanceComparing Summary
|
stormslowly
changed the title
stormslowly
changed the title
kdy1
reviewed
Jul 16, 2024
kdy1
reviewed
Jul 16, 2024
stormslowly
force-pushed
the
fix/tpl_raw_un_escaped
branch
from
de82dac
to
9393acf
Compare
kdy1
approved these changes
Jul 17, 2024
kdy1
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
convert
rawvalue tocookedfor creating new Tpl element.while optimizing nested tpl, after concatenating some cooked strs to assemble a new tpl element, the `raw` of the tpl should be escaped cooked string value.BREAKING CHANGE:
None
Related issue (if exists):
#9184