Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/plugin): Introduce manual-tokio-runtmie to swc crate #9701

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 1, 2024

Description:

This can cause a problem for Wasm plugin runtimes.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Nov 1, 2024
@kdy1 kdy1 self-assigned this Nov 1, 2024
@kdy1 kdy1 requested a review from a team as a code owner November 1, 2024 07:07
Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: 2162492

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) November 1, 2024 07:07
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 1, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 1, 2024
@kdy1 kdy1 disabled auto-merge November 1, 2024 07:34
@kdy1 kdy1 merged commit 97298c4 into swc-project:main Nov 1, 2024
147 of 151 checks passed
@kdy1 kdy1 deleted the plugin-tokio branch November 1, 2024 07:34
Copy link

codspeed-hq bot commented Nov 1, 2024

CodSpeed Performance Report

Merging #9701 will not alter performance

Comparing kdy1:plugin-tokio (2162492) with main (1c3eaf6)

Summary

✅ 194 untouched benchmarks

@kdy1 kdy1 modified the milestones: Planned, v1.8.0 Nov 4, 2024
@prisis
Copy link

prisis commented Nov 4, 2024

Stupid question but shouldnt it be "manual-tokio-runtime" and not "manual-tokio-runtmie"?

@kdy1
Copy link
Member Author

kdy1 commented Nov 4, 2024

Yeah you are right. It’a a typo and we need to add a feature with correct name (to avoid a breaking change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants