Skip to content

Commit

Permalink
Remove check for all_figures.html now that we are using Javascript
Browse files Browse the repository at this point in the history
  • Loading branch information
rgaiacs committed Nov 16, 2017
1 parent a747be0 commit 7e835fd
Showing 1 changed file with 0 additions and 34 deletions.
34 changes: 0 additions & 34 deletions bin/lesson_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
'%/LICENSE.md': True,
'%/README.md': False,
'%/_extras/discuss.md': True,
'%/_extras/figures.md': True,
'%/_extras/guide.md': True,
'%/index.md': True,
'%/reference.md': True,
Expand Down Expand Up @@ -116,7 +115,6 @@ def main():
for filename in docs.keys():
checker = create_checker(args, filename, docs[filename])
checker.check()
check_figures(args.source_dir, args.reporter)

args.reporter.report()

Expand Down Expand Up @@ -257,38 +255,6 @@ def check_fileset(source_dir, reporter, filenames_present):
seen)


def check_figures(source_dir, reporter):
"""Check that all figures are present and referenced."""

# Get references.
try:
all_figures_html = os.path.join(source_dir, '_includes', 'all_figures.html')
with open(all_figures_html, 'r') as reader:
text = reader.read()
figures = P_FIGURE_REFS.findall(text)
referenced = [os.path.split(f)[1] for f in figures if '/fig/' in f]
except FileNotFoundError as e:
reporter.add(all_figures_html,
'File not found')
return

# Get actual image files (ignore non-image files).
fig_dir_path = os.path.join(source_dir, 'fig')
actual = [f for f in os.listdir(fig_dir_path) if os.path.splitext(f)[1] in IMAGE_FILE_SUFFIX]

# Report differences.
unexpected = set(actual) - set(referenced)
reporter.check(not unexpected,
None,
'Unexpected image files: {0}',
', '.join(sorted(unexpected)))
missing = set(referenced) - set(actual)
reporter.check(not missing,
None,
'Missing image files: {0}',
', '.join(sorted(missing)))


def create_checker(args, filename, info):
"""Create appropriate checker for file."""

Expand Down

0 comments on commit 7e835fd

Please sign in to comment.