Replace print_date function in episode 16 question #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in #538, the function print_date was previously defined. This updated question will use print_time instead.
alee
requested changes
Apr 29, 2021
_episodes/16-writing-functions.md
Outdated
| > | ||
| > def print_date(year, month, day): | ||
| > joined = str(year) + '/' + str(month) + '/' + str(day) | ||
| > def print_date(hour, minute, second): |
There was a problem hiding this comment.
I think this needs to be renamed to print_time as well?
_episodes/16-writing-functions.md
Outdated
| @@ -203,26 +203,26 @@ result of call is: None | |||
| > 1. What's wrong in this example? | |||
| > | |||
| > ~~~ | |||
| > result = print_date(1871,3,19) | |||
| > result = print_time(11,37,59) | |||
There was a problem hiding this comment.
Please add spaces between the arguments here (and everywhere else that is missing them) for PEP8 compliance (and consistency with the rest of the lesson code snippets).
_episodes/16-writing-functions.md
Outdated
| > print(joined) | ||
| > ~~~ | ||
| > {: .language-python} | ||
| > | ||
| > 2. After fixing the problem above, explain why running this example code: | ||
| > | ||
| > ~~~ | ||
| > result = print_date(1871, 3, 19) | ||
| > result = print_time(11,37,59) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #538, the function
print_datewas previously used in the episode, leading to a student to potentially fail to experience the expected error if they type the code into their current python session.This updated question will use
print_timeinstead. This is a very simple substitution which I should be as accessible asprint_date.