Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword exercise #455

Closed
wants to merge 2 commits into from
Closed

Reword exercise #455

wants to merge 2 commits into from

Conversation

gcapes
Copy link
Contributor

@gcapes gcapes commented Feb 8, 2018

Fix #454.

@maxim-belkin
Copy link
Contributor

Thanks @gcapes! Could you please also fix the next sentence in this PR?

You can test your answers by typing the commands.

? "typing" does not test answers. "executing" does :)

@maxim-belkin maxim-belkin self-assigned this Apr 2, 2018
@maxim-belkin
Copy link
Contributor

I'd also suggest removing "You can". Invite attendees to test their answers:

Test your answers by executing the above commands

@MikeTrizna what are your thoughts on this one?

@MikeTrizna
Copy link
Contributor

I agree that in general, "execute" is much clearer command than "type". I also see that this distinction came up in e685495.

@maxim-belkin
Copy link
Contributor

Thanks, @gcapes!
Is this PR part of your instructor checkout process?

@gcapes
Copy link
Contributor Author

gcapes commented Apr 3, 2018

No worries!
We've never met but I maintain the Make lesson, so nope, this isn't for instructor checkout.

@gcapes gcapes closed this Apr 3, 2018
@gcapes gcapes reopened this Apr 3, 2018
@gcapes
Copy link
Contributor Author

gcapes commented Apr 3, 2018

Oops! Wrong button there!

@maxim-belkin
Copy link
Contributor

I think "Close pull request" button should be red AND on the left side :)
Thanks for your contribution, Gerard!

@gcapes gcapes deleted the 454 branch April 4, 2018 07:09
ldko pushed a commit that referenced this pull request Jun 16, 2020
@fmichonneau
add warning hook + CSS class for Rmd-based lessons (#455)
2f07ce1
zkamvar pushed a commit that referenced this pull request Apr 21, 2023
@gcapes @maxim-belkin
Reword exercise in 01-numpy.md
6636b9d 
Exercise: 'Check Your Understanding'

Closes #454

Closes #455

Signed-off-by: Maxim Belkin <maxim.belkin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maxim-belkin maxim-belkin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gcapes @maxim-belkin @MikeTrizna