Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use browser request props conditionally #184

Merged
merged 2 commits into from
Jul 30, 2024
Merged

use browser request props conditionally #184

merged 2 commits into from
Jul 30, 2024

Conversation

ericingram
Copy link
Contributor

Don't use credentials or mode request options in a server environment

@ericingram ericingram requested a review from awwit July 30, 2024 18:16
@swellmike
Copy link
Contributor

need to fix the unit test

@swellmike swellmike merged commit 9af96e5 into master Jul 30, 2024
1 check passed
@swellmike swellmike deleted the fix/server-side-request-props branch July 30, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swellmike swellmike swellmike approved these changes

@awwit awwit awwit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericingram @swellmike @awwit