Remove promise?.succeed(())

swift-server · Jan 25, 2023 · efa86b5 · efa86b5
1 parent 3f8f55f
commit efa86b5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/Sources/AsyncHTTPClient/ConnectionPool/HTTP1/HTTP1ClientChannelHandler.swift b/Sources/AsyncHTTPClient/ConnectionPool/HTTP1/HTTP1ClientChannelHandler.swift
@@ -157,7 +157,6 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
             metadata: req.requestFramingMetadata
         )
         self.run(action, context: context)
-        promise?.succeed(())
     }
 
     func read(context: ChannelHandlerContext) {

diff --git a/Tests/AsyncHTTPClientTests/HTTP1ClientChannelHandlerTests.swift b/Tests/AsyncHTTPClientTests/HTTP1ClientChannelHandlerTests.swift
@@ -554,7 +554,7 @@ class HTTP1ClientChannelHandlerTests: XCTestCase {
         // non empty body is important to trigger this bug as we otherwise finish the request in a single flush
         request.requestFramingMetadata.body = .fixedSize(1)
         request.raiseErrorIfUnimplementedMethodIsCalled = false
-        try channel.writeOutbound(request)
+        channel.writeAndFlush(request, promise: nil)
         XCTAssertEqual(request.events.map(\.kind), [.willExecuteRequest, .requestHeadSent])
     }
 }