cancelOnGracefulShutdown
hangs, if cancellation is not immediately
#177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently
cancelOnGracefulShutdown
hangs forever, if cancellation is not immediately but returns a eventually successful result (test case 1:testCancelOnGracefulShutdownSurvivesCancellation
).If the Cancellation leads to another error than
CancellationError
, this error is currently not propagated to the user (test case 2:testCancelOnGracefulShutdownSurvivesErrorThrown
).Changes
AsyncGracefulShutdownSequence
should never throw as this hides the real errors otherwiseCancellationWaiter
should never throw as this hides the real errors otherwisecancelOnGracefulShutdown
Result
cancelOnGracefulShutdown
works as expected